[PULP-1200] Fix edge case when creating metadata file #1102
+64
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobselko
commented
Feb 12, 2026
|
|
||
|
|
||
| def extract_wheel_metadata(filename: str) -> bytes | None: | ||
| def extract_non_normalized_pkg_name_with_version( |
Contributor
Author
There was a problem hiding this comment.
I have not found any function that already handles "de-normalization" so I created this one.
Contributor
There was a problem hiding this comment.
I don't understand, will packaging.utils.parse_wheel_filename not work here?
gerrod3
reviewed
Feb 13, 2026
Contributor
gerrod3
left a comment
gerrod3
left a comment
There was a problem hiding this comment.
I'm not sure if I'm comfortable with this regex parsing. I feel there has to be a library we can use to find the file name.
Some questions:
- The name in the metadata file doesn't have to be normalized (I think). Modern packages should be but old ones like some in our fixtures have mismatches. But does the name(path) of the metadata file have to be normalized?
pkg_info.wheeltakes the list of all the files in the wheel and tries to find the shortest path to a METADATA file. Is this the correct method we should copy? Seems kind of crazy, is there always a guaranteed that the main package will have the shortest path for its METADATA?- Do any of our packages in our fixtures have multiple metadata files? Can we find one for the tests?
|
|
||
|
|
||
| def extract_wheel_metadata(filename: str) -> bytes | None: | ||
| def extract_non_normalized_pkg_name_with_version( |
Contributor
There was a problem hiding this comment.
I don't understand, will packaging.utils.parse_wheel_filename not work here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1101
📜 Checklist
See: Pull Request Walkthrough