Fix Simple API cache poisoning via ?format=json - #1303
Merged
gerrod3 merged 1 commit intoJul 27, 2026
Conversation
Key the Simple API cache on the negotiated media type so a JSON response from ?format=json cannot be served for a later HTML request with the same Accept header. closes pulp#1302 Assisted By: Cursor Grok 4.5 Co-authored-by: Cursor <cursoragent@cursor.com>
gerrod3
force-pushed
the
cursor/fix-simple-api-cache-format-poison
branch
from
July 24, 2026 17:42
3cf0fe4 to
a16a5f0
Compare
gerrod3
marked this pull request as ready for review
July 24, 2026 18:19
jobselko
approved these changes
Jul 27, 2026
Backport to 3.32: 💚 backport PR created✅ Backport PR branch: Backported as #1304 🤖 @patchback |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PythonApiCacheon the negotiated media type instead of the rawAcceptheader so?format=jsonand HTML negotiation no longer share a cache entry?format=jsonpoison caseTest plan
oci-env test -p pulp_python functional -- -k test_simple_cache -v?format=jsonwarm followed by the same Accept withoutformatreturns HTML 200 (not 500)Made with Cursor