Prepare plugin for v4 API - #1326
Conversation
| r = re.compile( | ||
| rf""" | ||
| (?:{settings.API_ROOT}(?:[-_a-zA-Z0-9]+/)?api/v3/repositories/python/python/[-a-f0-9]+/) | ||
| (?:{settings.API_ROOT}(?:[-_a-zA-Z0-9]+/)?api/v\d+/repositories/python/python/[-a-f0-9]+/) |
ggainey
left a comment
There was a problem hiding this comment.
Change looks good - approved
|
|
Yes - but that's a global issue. See https://redhat.atlassian.net/browse/PULP-2220 - I want us to have a way for the tests to know what version of the API they are running against, so we can replace assertions with '/v3/' in them with something like '/VERSION/' and have everything Just Work. Asserting on strings that don't require the version-part, or substituting /v\d+/, is fine as well - but def want 2220 in next sprint, so we can have more-version-aware testing :) |
|
@ggainey Thanks for the clarification! So are you ok with fixing the test now? Or should we revert the change? |
Current state is fine. Since the test is really "does the domain-name show up in the HREF", and doesn't actually care about the version, this is better at defining what we're actually testing for. So we're good :) |
Update viewsets to accept **kwargs, fix hardcoded v3 urls.
https://redhat.atlassian.net/browse/PULP-2189
📜 Checklist
See: Pull Request Walkthrough