chore(rivet,ci): triage #443 (SR-53) + remove vestigial Dagger (closes #448) - #459
Merged
Conversation
… (v0.4.3) kilnd invokes param-taking functions with zero-filled args and reports the wrong result as success (exit 0); no CLI passes wasm params, and a param-arity-invalid component is accepted where wasm-tools/wasmtime reject it. Same fabricated-success family as #412 (SR-42). release v0.4.3. Trace: skip Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FcTUZgts331Z1TK3q8YBQj
Dagger is installed, PATH'd, cached and env-configured across three workflows
but never actually invoked — a complete check found:
- no `dagger call/run/query` anywhere;
- dagger-sdk is NOT a Cargo dependency (absent from Cargo.lock);
- cargo-kiln / kiln-build-core reference dagger zero times, so the
`cargo-kiln coverage` / `cargo-kiln docs` steps the setup wraps don't use it.
Removed:
- publish.yml: "Setup Dagger CLI", "Start Docker service (required for
Dagger)", "Check Dagger version" steps; the ~/.dagger/bin PATH exports;
the _EXPERIMENTAL_DAGGER_CLOUD_TOKEN / DAGGER_LOG_* env on the coverage
and docs steps.
- ci.yml: three "Dagger Engine Cache" steps (caching ~/.cache/dagger, never
written); the commented dagger_sdk RUST_LOG line; and two `if: false`
PlantUML setup steps whose only rationale was the non-existent
"CheckDocsStrict Dagger pipeline".
- security-audit.yml: the stale `pkg:cargo/dagger-sdk@0.11.10` license
allow-list entry (that package is not in the dependency graph).
The `cargo-kiln coverage`/`docs` commands are unchanged and run identically
without the Dagger setup. All three workflows still parse.
Also found, left for maintainer judgment: deploy-docs-sftp.yml.example still
references `cargo xtask publish-docs-dagger` (xtask is a removed legacy
component) — it's an .example template, not an active workflow.
Trace: skip
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FcTUZgts331Z1TK3q8YBQj
🔍 Build Diagnostics ReportSummary
🎯 Impact AnalysisIssues in Files You Modified
Cascading Issues (Your Changes Breaking Other Files)
✅ No Issues DetectedPerfect! Your changes don't introduce any new errors or warnings, and don't break any existing code. 📊 Full diagnostic data available in workflow artifacts 🔧 To reproduce locally: # Install cargo-kiln
cargo install --path cargo-kiln
# Analyze your changes
cargo-kiln build --output json --filter-severity error
cargo-kiln check --output json --filter-severity warning |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two housekeeping items from the tracker.
#448 — remove vestigial Dagger (
ci:commit)A complete check found Dagger is installed, PATH'd, cached and env-configured but never invoked:
dagger call/run/queryanywhere in the repo;dagger-sdkis not a Cargo dependency (absent fromCargo.lock);cargo-kiln/kiln-build-corereference dagger zero times, so thecargo-kiln coverage/cargo-kiln docssteps the setup wraps don't use it.Removed across
publish.yml(CLI install, Docker-for-Dagger, version check, PATH exports,DAGGER_*env),ci.yml(three~/.cache/daggercache steps that cache a never-written dir + commenteddagger_sdklog line + twoif: falsePlantUML steps predicated on the non-existent "CheckDocsStrict Dagger pipeline"), andsecurity-audit.yml(stalepkg:cargo/dagger-sdk@0.11.10allow-list entry). Net −58 lines; the actualcargo-kilncommands are unchanged; all three workflows still parse.Also found, left for your call:
deploy-docs-sftp.yml.examplereferencescargo xtask publish-docs-dagger(xtask is a removed legacy component) — but it's an.exampletemplate, not an active workflow, so I didn't touch it.#443 — SR-53 triage (
chore(rivet):commit)Lands the arg-arity fabricated-success bug (kilnd zero-fills missing params and reports the wrong result as
✓ success) as rivet SR-53,release: v0.4.3. The code fix is in flight on a separate branch (fix/sr-53-...).rivet validate: 0 errors.🤖 Generated with Claude Code