Skip to content

chore(rivet,ci): triage #443 (SR-53) + remove vestigial Dagger (closes #448) - #459

Merged
avrabe merged 2 commits into
mainfrom
chore/triage-443-448
Jul 21, 2026
Merged

chore(rivet,ci): triage #443 (SR-53) + remove vestigial Dagger (closes #448)#459
avrabe merged 2 commits into
mainfrom
chore/triage-443-448

Conversation

@avrabe

@avrabe avrabe commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Two housekeeping items from the tracker.

#448 — remove vestigial Dagger (ci: commit)

A complete check found Dagger is installed, PATH'd, cached and env-configured but never invoked:

  • no dagger call/run/query anywhere in the repo;
  • dagger-sdk is not a Cargo dependency (absent from Cargo.lock);
  • cargo-kiln / kiln-build-core reference dagger zero times, so the cargo-kiln coverage / cargo-kiln docs steps the setup wraps don't use it.

Removed across publish.yml (CLI install, Docker-for-Dagger, version check, PATH exports, DAGGER_* env), ci.yml (three ~/.cache/dagger cache steps that cache a never-written dir + commented dagger_sdk log line + two if: false PlantUML steps predicated on the non-existent "CheckDocsStrict Dagger pipeline"), and security-audit.yml (stale pkg:cargo/dagger-sdk@0.11.10 allow-list entry). Net −58 lines; the actual cargo-kiln commands are unchanged; all three workflows still parse.

Also found, left for your call: deploy-docs-sftp.yml.example references cargo xtask publish-docs-dagger (xtask is a removed legacy component) — but it's an .example template, not an active workflow, so I didn't touch it.

#443 — SR-53 triage (chore(rivet): commit)

Lands the arg-arity fabricated-success bug (kilnd zero-fills missing params and reports the wrong result as ✓ success) as rivet SR-53, release: v0.4.3. The code fix is in flight on a separate branch (fix/sr-53-...).

rivet validate: 0 errors.

🤖 Generated with Claude Code

avrabe and others added 2 commits July 21, 2026 22:44
… (v0.4.3)

kilnd invokes param-taking functions with zero-filled args and reports the
wrong result as success (exit 0); no CLI passes wasm params, and a
param-arity-invalid component is accepted where wasm-tools/wasmtime reject it.
Same fabricated-success family as #412 (SR-42). release v0.4.3.

Trace: skip
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FcTUZgts331Z1TK3q8YBQj
Dagger is installed, PATH'd, cached and env-configured across three workflows
but never actually invoked — a complete check found:
  - no `dagger call/run/query` anywhere;
  - dagger-sdk is NOT a Cargo dependency (absent from Cargo.lock);
  - cargo-kiln / kiln-build-core reference dagger zero times, so the
    `cargo-kiln coverage` / `cargo-kiln docs` steps the setup wraps don't use it.

Removed:
  - publish.yml: "Setup Dagger CLI", "Start Docker service (required for
    Dagger)", "Check Dagger version" steps; the ~/.dagger/bin PATH exports;
    the _EXPERIMENTAL_DAGGER_CLOUD_TOKEN / DAGGER_LOG_* env on the coverage
    and docs steps.
  - ci.yml: three "Dagger Engine Cache" steps (caching ~/.cache/dagger, never
    written); the commented dagger_sdk RUST_LOG line; and two `if: false`
    PlantUML setup steps whose only rationale was the non-existent
    "CheckDocsStrict Dagger pipeline".
  - security-audit.yml: the stale `pkg:cargo/dagger-sdk@0.11.10` license
    allow-list entry (that package is not in the dependency graph).

The `cargo-kiln coverage`/`docs` commands are unchanged and run identically
without the Dagger setup. All three workflows still parse.

Also found, left for maintainer judgment: deploy-docs-sftp.yml.example still
references `cargo xtask publish-docs-dagger` (xtask is a removed legacy
component) — it's an .example template, not an active workflow.

Trace: skip
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FcTUZgts331Z1TK3q8YBQj
@github-actions

Copy link
Copy Markdown

🔍 Build Diagnostics Report

Summary

Metric Base Branch This PR Change
Errors 0 0 0
Warnings 5 5 0

🎯 Impact Analysis

Issues in Files You Modified

  • 0 new errors introduced by your changes
  • 0 new warnings introduced by your changes
  • 0 total errors in modified files
  • 0 total warnings in modified files
  • 0 files you modified

Cascading Issues (Your Changes Breaking Other Files)

  • 0 new errors in unchanged files
  • 0 new warnings in unchanged files
  • 0 unchanged files now affected

Note: "Cascading issues" are errors in files you didn't modify, caused by your changes (e.g., breaking API changes, dependency issues).

✅ No Issues Detected

Perfect! Your changes don't introduce any new errors or warnings, and don't break any existing code.


📊 Full diagnostic data available in workflow artifacts

🔧 To reproduce locally:

# Install cargo-kiln
cargo install --path cargo-kiln

# Analyze your changes
cargo-kiln build --output json --filter-severity error
cargo-kiln check --output json --filter-severity warning

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@avrabe
avrabe merged commit 7b57aeb into main Jul 21, 2026
22 checks passed
@avrabe
avrabe deleted the chore/triage-443-448 branch July 21, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant