fix(repo-hygiene): quiesce check must match the command name, not the path - #154
Merged
Conversation
… path Step 0's `ps aux | grep -E 'cargo|rustc|bazel'` matches any binary installed under ~/.cargo/bin, plus anything whose arguments mention such a path. On a normal developer machine it is near-permanently non-empty, so the sweep would abort every time — the skill's first gate made the skill unusable. Reproduced independently on an idle machine: the old check returns 5 matches, `pgrep -x 'cargo|rustc|bazel'` returns 0. Switches to pgrep -x, notes the portable `ps -eo comm=` equivalent, and warns that the same name-vs-path care applies anywhere the skill greps ps. Also adds the anti-pattern the reporter named: a precondition that cries wolf gets routed around by habit, and is then ignored the once it fires for real — the human-factors twin of the vacuous gate. A guard that misfires is a bug in the guard, not something to learn to skip. repo-hygiene 0.1.0 -> 0.1.1; plugin 0.16.1 -> 0.16.2. Closes #149 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(repo-hygiene): quiesce check must match the command name, not the path
Step 0's
ps aux | grep -E 'cargo|rustc|bazel'matches any binary installedunder ~/.cargo/bin, plus anything whose arguments mention such a path. On a
normal developer machine it is near-permanently non-empty, so the sweep would
abort every time — the skill's first gate made the skill unusable.
Reproduced independently on an idle machine: the old check returns 5 matches,
pgrep -x 'cargo|rustc|bazel'returns 0.Switches to pgrep -x, notes the portable
ps -eo comm=equivalent, and warnsthat the same name-vs-path care applies anywhere the skill greps ps.
Also adds the anti-pattern the reporter named: a precondition that cries wolf
gets routed around by habit, and is then ignored the once it fires for real —
the human-factors twin of the vacuous gate. A guard that misfires is a bug in
the guard, not something to learn to skip.
repo-hygiene 0.1.0 -> 0.1.1; plugin 0.16.1 -> 0.16.2.
Closes #149
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com