fix(release): install wasm32-unknown-unknown — v1.131.0 shipped without components - #332
Merged
Merged
Conversation
…ut components Regression from #329. That PR switched no_std components to build wasm32-unknown-unknown, but the flight-component job's toolchain only installs wasm32-wasip2, so the release failed at: building rate (wasm32-unknown-unknown)... ERROR: no .wasm found I verified #329 locally, where I had run `rustup target add wasm32-unknown-unknown` — and did not check the environment that actually matters. Same class as the wasip1-vs-wasip2 mistake: right property, wrong environment. Add both targets to the job. WHAT THE GUARD DID AND DID NOT CATCH — the fail-loud from #323 worked: the build aborted instead of falling through to a stale artifact, and the ghcr publish was SKIPPED rather than shipping something wrong. Nothing bad was published; ghcr still serves 1.129.0/1.130.0 only. What it could not prevent: `create-release` runs BEFORE `flight-component`, so the v1.131.0 GitHub release was already published (12 assets: binaries, SBOM, sums) and is now missing its wasm components. It is incomplete, not incorrect — consumers pulling components still resolve to 1.130.0. v1.131.0's notes will be marked superseded and the complete release cut as v1.131.1 rather than moving a published tag. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HvusAXYbHLyv3uTzfBcMbG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from #329
#329 switched no_std components to
wasm32-unknown-unknown, but the flight-component job's toolchain only installswasm32-wasip2:My error, and a familiar one: I verified #329 locally — where I'd run
rustup target add wasm32-unknown-unknown— and didn't check the environment that actually matters. Same class as the wasip1-vs-wasip2 mistake earlier in this arc: right property, wrong environment.What the guard caught, and what it couldn't
Worked (#323 fail-loud): the build aborted instead of falling through to a stale artifact, and the ghcr publish was skipped rather than shipping something wrong. Nothing bad was published — ghcr still serves 1.129.0/1.130.0 only.
Couldn't prevent:
create-releaseruns beforeflight-component, so the v1.131.0 GitHub release was already published (12 assets — binaries, SBOM, sums) and is missing its wasm components. It is incomplete, not incorrect; consumers pulling components still resolve to 1.130.0.Plan
Mark v1.131.0's notes superseded and cut the complete release as v1.131.1 — rather than moving a published tag.
🤖 Generated with Claude Code