release(v0.13.1): silent-failure closeout + release-pipeline standardization#333
Open
avrabe wants to merge 1 commit into
Open
release(v0.13.1): silent-failure closeout + release-pipeline standardization#333avrabe wants to merge 1 commit into
avrabe wants to merge 1 commit into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: a00b5cd | Previous: fce5dff | Ratio |
|---|---|---|---|
store_insert/10000 |
19490362 ns/iter (± 1367640) |
15655075 ns/iter (± 981015) |
1.24 |
link_graph_build/10000 |
40303436 ns/iter (± 2489824) |
27552219 ns/iter (± 1885336) |
1.46 |
validate/10000 |
23546029 ns/iter (± 1653196) |
13419892 ns/iter (± 138543) |
1.75 |
diff/10000 |
10519486 ns/iter (± 768863) |
8331905 ns/iter (± 299545) |
1.26 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
avrabe
added a commit
that referenced
this pull request
May 26, 2026
Same TCP-read flake observed on PR #333's Proptest (extended) job — `reload_returns_hx_location` panicked with an empty response body, the exact same flake class `post_reload_status` was added to handle for the sibling `test_reload_yaml_error` test in this PR's prior commit. Extract `post_reload_response` (full response body, with optional `HX-Current-URL:` header) that retries once on empty body after a 200 ms backoff. Rewrite `reload_returns_hx_location` to use it. The two helpers (`post_reload_status` returning status, the new `post_reload_response` returning the full body) cover the two distinct shape of POST-and-inspect-result the reload tests need. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
avrabe
added a commit
that referenced
this pull request
May 27, 2026
…y) (#331) * test(serve): stabilize test_reload_yaml_error_returns_error_response Same transient-connection-drop flake class that landed in fetch_page_with_retry (PR-train preceding v0.13.0). The raw TcpStream POST + read_to_end occasionally returns empty data on self-hosted-runner contention, leaving the HTTP status parsed as 0 and the assertion failing with "got status 0" — observed on PR #328 (no serve-code change in the PR, the failure was the test, not the production code). Extract a `post_reload_status` helper that retries once on `status == 0` after a 200 ms backoff (mirroring fetch_page_with_retry exactly), and use it from test_reload_yaml_error_returns_error_response. The other reload tests already work fine via fetch_with_timeout so they don't need the helper yet. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * test(serve): extend retry-on-empty-body to reload_returns_hx_location Same TCP-read flake observed on PR #333's Proptest (extended) job — `reload_returns_hx_location` panicked with an empty response body, the exact same flake class `post_reload_status` was added to handle for the sibling `test_reload_yaml_error` test in this PR's prior commit. Extract `post_reload_response` (full response body, with optional `HX-Current-URL:` header) that retries once on empty body after a 200 ms backoff. Rewrite `reload_returns_hx_location` to use it. The two helpers (`post_reload_status` returning status, the new `post_reload_response` returning the full body) cover the two distinct shape of POST-and-inspect-result the reload tests need. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * chore(fmt): rustfmt collapses map_or closure to single line --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Bumps workspace + vscode-rivet to 0.13.1. CHANGELOG captures the v0.13.1 theme — silent-failure closeout (REQ-091, rowan-yaml flush-left link loss + extract_links_via_serde loud-fail), release-pipeline standardization to the cross-repo synth pattern (SBOM + SLSA + build-env), spar `84a7363` → tag bump, and the MODULE.bazel `rules_wasm_component` git_override that unblocked Rocq Proofs CI on every PR. This is the release-prep commit; the substantive PRs (#328, #329, #330, #327) merge first, this branch is rebased onto the merged main, then merged + tagged. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v0.13.1
Version bump (0.13.0 → 0.13.1) + CHANGELOG entry for the train just landed.
What shipped
Six PRs constitute v0.13.1:
Headline
REQ-091 closes an F2 silent-failure where the salsa-incremental `rivet validate` path graded zero links for artifacts written in YAML's zero-indent (flush-left) list style — the format `serde_yaml::to_string` emits. The `extract_links_via_serde` fallback now emits a parse diagnostic instead of silently returning `Vec::new()`. Surfaced previously-silent cardinality errors in the dev → aspice migration test; test updated to document the migration's actual structural-only contract.
v0.13.1 also ships
Permission deniedfor every PR since v0.11.x).Verification (post-release, paste into release notes)
```bash
cosign verify-blob \
--certificate-identity-regexp \
'https://github.com/pulseengine/rivet/.github/workflows/release.yml@.*' \
--certificate-oidc-issuer \
'https://token.actions.githubusercontent.com' \
--bundle SHA256SUMS.txt.cosign.bundle SHA256SUMS.txt
gh attestation verify rivet-v0.13.1-.tar.gz \
--repo pulseengine/rivet
```
Test plan
🤖 Generated with Claude Code