feat(modify): wire --set-description flag + clearer usage (#359, #360)#365
Merged
Conversation
#360) Agent-reported. `description` is a top-level base field but the CLI exposed no `--set-description` flag, so updating it forced `--set-field description=...`, which mutate then REJECTED with a hint pointing at a `--set-description` flag that did not exist — a dead-end loop. The core (`ModifyParams.set_description`, `yaml_edit`) already applied it; only the clap wiring was missing. - `rivet modify <ID> --set-description "<text>"` now works (#360). - `rivet modify --help` shows `--set-*` examples + a note that positionals (`modify <ID> status approved`) are not valid (#359; the bare clap error still directs to --help, which now teaches the pattern). Regression test modify_applies_set_description_param. Verified end-to-end. Implements: REQ-136 Verifies: REQ-136 Refs: REQ-007 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
📐 Rivet artifact deltaNo artifact changes in this PR. Code-only changes (renderer, CLI wiring, tests) don't touch the artifact graph. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 523d3a6 | Previous: bc2f32a | Ratio |
|---|---|---|---|
store_lookup/1000 |
24708 ns/iter (± 70) |
19294 ns/iter (± 341) |
1.28 |
diff/1000 |
729161 ns/iter (± 3082) |
600716 ns/iter (± 8617) |
1.21 |
query/1000 |
6963 ns/iter (± 49) |
5266 ns/iter (± 57) |
1.32 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced May 31, 2026
avrabe
added a commit
that referenced
this pull request
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the #360 dead-end (and improves #359):
descriptionis a top-level base field, but the CLI had no--set-descriptionflag — so--set-field description=...was rejected with a hint pointing at a flag that didn't exist. The core already supported it (ModifyParams.set_description+yaml_edit); only the clap wiring was missing.rivet modify <ID> --set-description "text"now works.rivet modify --helpshows--set-*examples + a 'positionals not valid' note.Regression test + verified end-to-end. (REQ-136.)
🤖 Generated with Claude Code