docs(artifacts): mark REQ-136 implemented#367
Merged
Conversation
📐 Rivet artifact delta
Graphgraph LR
REQ_136["REQ-136"]:::modified
classDef added fill:#d4edda,stroke:#28a745,color:#155724
classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3
Modified
Posted by |
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: adcc117 | Previous: 68bc025 | Ratio |
|---|---|---|---|
store_lookup/100 |
2176 ns/iter (± 5) |
1660 ns/iter (± 3) |
1.31 |
store_lookup/1000 |
26023 ns/iter (± 200) |
19535 ns/iter (± 508) |
1.33 |
traceability_matrix/100 |
5085 ns/iter (± 12) |
3904 ns/iter (± 7) |
1.30 |
traceability_matrix/1000 |
61972 ns/iter (± 268) |
41047 ns/iter (± 92) |
1.51 |
query/1000 |
7197 ns/iter (± 33) |
5292 ns/iter (± 27) |
1.36 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark-implemented sweep: REQ-136 (modify ergonomics) shipped via #365. REQ-137 was already set implemented in #366.
rivet validatePASS.