feat(validate): --min-severity display filter to cut advisory noise (#357)#366
Merged
Merged
Conversation
…357) Self-reported dogfooding finding. `rivet validate` printed every diagnostic regardless of severity — on rivet's own repo ~160 advisory warnings for 0 errors, burying anything actionable. `--fail-on` gates the exit code but still prints everything. New `rivet validate --min-severity <error|warning|info>` displays only diagnostics at or above the floor (text output). Counts + exit code are unchanged (computed from the full set); when the filter hides anything, a one-line note reports "showing N of M … at or above '<level>'" so nothing is silently dropped. Reuses the existing --fail-on severity parser. Regression test validate_min_severity_filters_display. Filed as REQ-137 (implemented). Implements: REQ-137 Verifies: REQ-137 Refs: REQ-004 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
📐 Rivet artifact delta
Graphgraph LR
REQ_137["REQ-137"]:::added
classDef added fill:#d4edda,stroke:#28a745,color:#155724
classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3
Added
Posted by |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #357 (my own dogfooding finding).
rivet validateprinted every diagnostic; on a clean repo that is ~160 advisory warnings for 0 errors, burying anything actionable.rivet validate --min-severity error(orwarning/info) now displays only diagnostics at/above the floor, with a one-line note of how many were suppressed. Counts + exit code unchanged (display-only) — loud-fail preserved. Reuses the--fail-onparser. Regression test + verified on rivet's repo (--min-severity error→ 'showing 0 of 356'). REQ-137.🤖 Generated with Claude Code