feat(modify): --where <s-expr> for query-driven bulk modify (REQ-141)

[avrabe]

What

Bringing a real project's requirement statuses in line with shipped code (the bulk draft → implemented task in #353) had no first-class tool — only a shell loop of per-ID rivet modify calls, which the reporter found silently no-op'd under redirection (a suspected reload/rewrite race between rapid-succession subprocesses).

rivet modify --where '<s-expr>' --set-* selects every artifact matching the same s-expression filter rivet query uses and applies the change in a single in-process pass — load once, validate every target up front (all-or-nothing), then write each affected file once. No subprocess re-spawn, so it cannot race the way the shell loop could.

rivet modify --where '(= status "draft")' --set-status implemented            # bulk apply
rivet modify --where '(and (type "requirement") (status "draft"))' \
             --set-status implemented --dry-run                                # preview

• --where is mutually exclusive with a positional <ID> (clap-enforced).
• --dry-run previews the match set, writes nothing.
• An empty match set is a loud no-op (no artifacts match the --where filter) — silence is never read as success.
• Reuses the existing sexpr_eval engine — no new filter dialect (design on existing patterns).

Verification

End-to-end on a scratch project: dry-run leaves files byte-identical; bulk apply flips only the matches (non-matches untouched) and prints modified N artifacts; empty match → loud no-op; ID + --where rejected. New rivet-cli/tests/modify_where.rs (4 cases, all green); clippy --all-targets + fmt clean; rivet validate → PASS.

Triage context (#353)

This closes the bulk --set-status / --where feature ask and addresses Part 3 (the racy shell loop) at its root — by removing the need for the loop entirely. Earlier parts of #353 were already handled: Part 1 (silent file-skip) by REQ-062, Part 4 (WARN noise) by #379/REQ-139. The remaining open item is the cross-command parse inconsistency filed as REQ-140 (maintainer design call).

Implements: REQ-141

🤖 Generated with Claude Code

[github-actions]

📐 Rivet artifact delta

Change	Count
Added	1
Removed	0
Modified	0
Downstream impacted (depth ≤ 5)	0

Graph

graph LR
  REQ_141["REQ-141"]:::added
  classDef added fill:#d4edda,stroke:#28a745,color:#155724
  classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
  classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
  classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3

Loading

Added

• REQ-141

📎 Full HTML dashboard attached as workflow artifact rivet-delta-pr-380 — download from the workflow run.

_{Posted by rivet-delta workflow. The graph shows only changed artifacts; open the HTML dashboard (above) for full context.}

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: f29cd39	Previous: ab298f5	Ratio
store_lookup/100	2222 ns/iter (± 73)	1664 ns/iter (± 4)	1.34
store_lookup/1000	25996 ns/iter (± 128)	19453 ns/iter (± 50)	1.34
traceability_matrix/1000	61475 ns/iter (± 166)	41005 ns/iter (± 99)	1.50
query/100	749 ns/iter (± 1)	612 ns/iter (± 3)	1.22
query/1000	7376 ns/iter (± 33)	5134 ns/iter (± 100)	1.44

This comment was automatically generated by workflow using github-action-benchmark.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!