fix(modify): correct s-expr syntax in --where help examples (REQ-141)#382
Merged
Conversation
The `modify --where` after_help examples I added in #380 used an invalid filter shorthand — `(type "requirement")` / `(status "draft")` — where the head symbol must be an operator, not the field name. Run verbatim they error with "unknown form 'type'/'status'". Corrected to the canonical `(= field "value")` form, both examples now run clean: rivet modify --where '(= status "draft")' --set-status implemented rivet modify --where '(and (= type "requirement") (= status "draft"))' … Verified both examples execute (dry-run) without a parse error. The broader discoverability gap (the parse error shows no example of the common field-equality form) is tracked in #381. Implements: REQ-141 Refs: REQ-007 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
📐 Rivet artifact deltaNo artifact changes in this PR. Code-only changes (renderer, CLI wiring, tests) don't touch the artifact graph. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #380. The
modify --whereafter_help examples I added used an invalid filter shorthand —(type "requirement")/(status "draft")— where the s-expr head must be an operator, not the field name. Run verbatim they error (unknown form 'type'). Corrected to the canonical(= field "value")form:Verified both now execute (dry-run) without a parse error. Caught while filing #381 (the parse error shows no example of the common field-equality form — the broader discoverability fix is tracked there).
Implements: REQ-141
🤖 Generated with Claude Code