fix(ci): harden cargo-deny step (post-#106 cleanup)#107
Merged
Conversation
Issue #103 was largely closed in PR #106 (smithy runner migration), which replaced EmbarkStudios/cargo-deny-action@v2 with rustup + direct `cargo install --locked` + `cargo deny check`. This commit cleans up two residual defects in that step: 1. The install command was wrapped in `|| true`, so an install failure was silently swallowed and the next step would fail with a confusing "command not found". Drop the `|| true` so install failure fails the job loudly with a clear error. 2. Add explicit `name:` labels to the install / check steps so CI logs are readable. 3. Rewrite the rationale comment to reference the rust-toolchain.toml / musl interaction (the actual root cause of #103) with the smithy rootless-container note as secondary context. The duplicate `thiserror` 1.x/2.x versions cargo-deny will likely re-flag once it actually runs cleanly are out of scope here; will file a follow-up if it surfaces. Fixes: #103 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
avrabe
added a commit
that referenced
this pull request
May 11, 2026
Patch release bundling four merged PRs: #107 — cargo-deny CI step hardening (closes #103) #108 — discharge lemma_le64_injective Verus admit (audit C-1 partial) #109 — repair fuzz_public_key target (audit follow-up from #98) #110 — clear 3 RUSTSEC advisories via dep bumps (fixes #102) Companion work on 0.8.2+next: #111 — criterion benches for signature verification (#89) #112 — lift Kani wasm_module mask; document merkle + format See CHANGELOG.md for the full release notes. Trace: skip Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up two residual defects in the `Cargo Deny` step that PR #106 (smithy runner migration) replaced. Closes #103.
Context
Issue #103 reported that `Cargo Deny` was failing because `EmbarkStudios/cargo-deny-action@v2` ran in a musl container that couldn't install the toolchain pinned by `rust-toolchain.toml`. PR #106 already replaced the action with a direct rustup + `cargo install --locked` + `cargo deny check` flow on a regular runner. So the original symptom is gone.
But two minor defects remained in that direct flow:
Out of scope (follow-up)
The agent who reviewed this flagged that `thiserror` 1.x and 2.x are duplicated in the dep graph. cargo-deny will likely flag this on the first clean run after this lands. If so, that's a separate, smaller PR.
Test plan
Closes #103.