feat(benches): criterion benches for signature verification (#89)#111
Merged
Conversation
Automated review for PR #111pulseengine/sigil: Verdict: 💬 Comment Summary: The pull request is approved. Findings: 0 mechanical (rivet) · 1 from local AI model. Findings (1):
Generated by a local AI model and post-validated against a strict JSON contract. Each finding includes the verbatim line being criticised — verify by reading the file at the cited location. Reviewed at |
5 tasks
avrabe
added a commit
that referenced
this pull request
May 11, 2026
Patch release bundling four merged PRs: #107 — cargo-deny CI step hardening (closes #103) #108 — discharge lemma_le64_injective Verus admit (audit C-1 partial) #109 — repair fuzz_public_key target (audit follow-up from #98) #110 — clear 3 RUSTSEC advisories via dep bumps (fixes #102) Companion work on 0.8.2+next: #111 — criterion benches for signature verification (#89) #112 — lift Kani wasm_module mask; document merkle + format See CHANGELOG.md for the full release notes. Trace: skip Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds criterion-driven benchmarks for the four signature-verification hot paths: Ed25519 verify, DSSE envelope parse+verify, Merkle tree validation (parameterised by leaf count), and cert-chain validation (parameterised by chain length, matching MAX_CHAIN_DEPTH=8 from audit PR #98). SLH-DSA bench deferred to issue #46. CI integration deferred to a follow-up PR — this commit only lands the bench harness so baselines can be captured. Traceability comments at the top of the bench file link each group to its CR-* artifact. Implements: #89 Verifies: CR-1, CR-3, CR-7, CR-8 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
7fe1f07 to
8732faf
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #89. Adds criterion-driven benchmarks for the four signature-verification hot paths so silent crypto-path regressions can be caught before they ship.
Bench groups
Deferred
Validation
Implements #89. Verifies CR-1, CR-3, CR-7, CR-8.