Skip to content

feat: Write ESC with K8 using ESO doc/tutorial #13578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 11, 2024
Merged

feat: Write ESC with K8 using ESO doc/tutorial #13578

merged 4 commits into from
Dec 11, 2024

Conversation

@dirien
Copy link
Contributor

@dirien dirien commented Dec 11, 2024

Proposed changes

Unreleased product version (optional)

Related issues (optional)

closes #13173

@dirien dirien requested a review from a team as a code owner December 11, 2024 11:35
@dirien dirien requested a review from interurban December 11, 2024 11:35
@pulumi-bot
Copy link
Collaborator

pulumi-bot commented Dec 11, 2024

Your site preview for commit b0a6a18 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13578-b0a6a18a.s3-website.us-west-2.amazonaws.com.

toriancrane
toriancrane suggested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@toriancrane toriancrane left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Just a few changes requested. I did not test the code.

@dirien @toriancrane
Update content/tutorials/esc-external-secret-operator/index.md
8e251be 
Co-authored-by: Torian Crane <toriancrane@gmail.com>
@pulumi-bot
Copy link
Collaborator

pulumi-bot commented Dec 11, 2024

Your site preview for commit 8e251be is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13578-8e251be4.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

pulumi-bot commented Dec 11, 2024

Your site preview for commit b5f5058 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13578-b5f50580.s3-website.us-west-2.amazonaws.com.

@dirien dirien requested a review from toriancrane December 11, 2024 16:52
@dirien
Copy link
Contributor Author

dirien commented Dec 11, 2024

@toriancrane Thanks for the feedback. WDYT with the changes?

toriancrane
toriancrane approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@toriancrane toriancrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One minor typo but nothing that stops merging.

@dirien
Copy link
Contributor Author

dirien commented Dec 11, 2024

@toriancrane Alderauge!!! Thanks!

@dirien dirien enabled auto-merge (squash) December 11, 2024 18:18
@dirien dirien disabled auto-merge December 11, 2024 18:22
@pulumi-bot
Copy link
Collaborator

pulumi-bot commented Dec 11, 2024

Your site preview for commit eeaafdc is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13578-eeaafdca.s3-website.us-west-2.amazonaws.com.

thoward
thoward suggested changes Dec 11, 2024
View reviewed changes
@dirien dirien requested a review from thoward December 11, 2024 19:52
@pulumi-bot
Copy link
Collaborator

pulumi-bot commented Dec 11, 2024

Your site preview for commit 0d9a8bb is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13578-0d9a8bb4.s3-website.us-west-2.amazonaws.com.

@dirien dirien enabled auto-merge (squash) December 11, 2024 19:58
@dirien dirien merged commit c6669fb into master Dec 11, 2024
8 checks passed
@dirien dirien deleted the eso-doc-tutorial branch December 11, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@interurban interurban Awaiting requested review from interurban

2 more reviewers

@thoward thoward thoward approved these changes

@toriancrane toriancrane toriancrane approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Write ESC with K8 using ESO doc/tutorial

5 participants

@dirien @pulumi-bot @thoward @toriancrane