Use multi_json 1.15.0 only for ruby 2.7 #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An update to multi_json 1.16.0 specified ruby > 3.2; this started failing on ubuntu vms, probably a bug with the "only install gem dependencies that satisfy the currently running ruby" in ruby < 3.x. This change forces 1.15.0 to be installed first, which ruby will then use for the installation of puppet itself.
joshcooper
approved these changes
Jul 11, 2025
joshcooper
reviewed
Jul 11, 2025
| run: | | ||
| ${{ matrix.extra_steps }} | ||
| curl https://nightlies.puppet.com/downloads/gems/puppet${{ matrix.puppet_version }}-nightly/${{ matrix.gem_file }} --output puppet.gem --location | ||
| if [[ ${{ matrix.ruby }} == "2.7" ]]; then |
There was a problem hiding this comment.
gah, seems this code is executed on Windows too, which doesn't know what to do with bash-isms https://github.com/puppetlabs/puppetlabs-puppet_agent/actions/runs/16210067256/job/45768327368?pr=786#step:4:31
Maybe add a separate step which is conditional on the ruby version:
- name: Install multijson 1.15.0
if ${{ startsWith(matrix.ruby, '2.7') }}
run: gem install multi_json -v 1.15.0
- name: Install the latest nightly build of puppet${{ matrix.puppet_version }} gem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An update to multi_json 1.16.0 specified ruby > 3.2; this started failing on ubuntu vms, probably a bug with the "only install gem dependencies that satisfy the currently running ruby" in ruby < 3.x. This change forces 1.15.0 to be installed first, which ruby will then use for the installation of puppet itself.