Skip to content

Use multi_json 1.15.0 only for ruby 2.7 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
Merged

Use multi_json 1.15.0 only for ruby 2.7 #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/unit_tests_with_nightly_puppet_gem.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ jobs:
run: |
${{ matrix.extra_steps }}
curl https://nightlies.puppet.com/downloads/gems/puppet${{ matrix.puppet_version }}-nightly/${{ matrix.gem_file }} --output puppet.gem --location
if [[ ${{ matrix.ruby }} == "2.7" ]]; then
Copy link
Contributor

@joshcooper joshcooper Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gah, seems this code is executed on Windows too, which doesn't know what to do with bash-isms https://github.com/puppetlabs/puppetlabs-puppet_agent/actions/runs/16210067256/job/45768327368?pr=786#step:4:31

Maybe add a separate step which is conditional on the ruby version:

- name: Install multijson 1.15.0
  if ${{ startsWith(matrix.ruby, '2.7') }}
  run: gem install multi_json -v 1.15.0
- name: Install the latest nightly build of puppet${{ matrix.puppet_version }} gem

gem install multi_json -v 1.15.0
fi
gem install puppet.gem -N

- name: Prepare testing environment with bundler
Expand Down