(GH-56) OutLineView #59
Conversation
jpogran
force-pushed
the
GH-56-outlineview
branch
14 times, most recently
from
a0d5ce0 to
4068ce8
Compare
|
@glennsarti Initial commits squashed, tests fixed. First pass attempt at making rubocop happy. Still todo: determine symbol icons and remove debug list of symbols |
jpogran
force-pushed
the
GH-56-outlineview
branch
7 times, most recently
from
51f5e8e to
ed00d82
Compare
|
puppetlabs/puppet-vscode#395 has been merged so this PR can be used by the client now. |
| describe 'PuppetLanguageServer::PuppetParserHelper' do | ||
| let(:subject) { PuppetLanguageServer::PuppetParserHelper } | ||
| describe 'PuppetLanguageServer::Manifest::DocumentSymbolProvider', | ||
| :if => Gem::Version.new(Puppet.version) >= Gem::Version.new('5.0.0') do |
There was a problem hiding this comment.
What happens on Puppet 4? Curious why we aren't testing on it?
|
@jpogran I've update your branch with tests for Puppet 4 and some minor fixes. |
jpogran
force-pushed
the
GH-56-outlineview
branch
from
7f5de7d to
ab661e6
Compare
|
Squashed commits and updated changelog |
|
@glennsarti @michaeltlombardi I think we're good to merge this in today |
| begin | ||
| case documents.document_type(file_uri) | ||
| when :manifest | ||
| r = PuppetLanguageServer::PuppetParserHelper.extract_document_symbols(content) |
There was a problem hiding this comment.
I'm suprised rubocop didn't complain about the single letter variable.
| graph | ||
| end | ||
|
|
||
| def self.extract_document_symbols(content) |
| begin | ||
| case documents.document_type(file_uri) | ||
| when :manifest | ||
| r = PuppetLanguageServer::PuppetParserHelper.extract_document_symbols(content) |
There was a problem hiding this comment.
This should be using PuppetLanguageServer::Manifest::DocumentSymbolProvider
This commit adds the DocumentSymbolProvider and supporting code to the LanguageServer. It uses a procedural implementation to parse the output of the Puppet AST to generate symbols that VSCode understands. This lights up OutlineView, Breadcrumbs, and symbol search using the command pallete.
This commit builds on the procedural DocumentSymbolProvider and makes it a recursive one. This does not support the Puppet 4 AST, and returns an empty array.
jpogran
force-pushed
the
GH-56-outlineview
branch
from
ab661e6 to
bd64c96
Compare
|
@glennsarti please review...again |
2 participants
This PR implements a DocumentSymbolProvider for the LanguageServer. It parses Puppet manifests and produce symbols for classes, types, parameters and variables.