(GH-337) Update vscode-languageclient and vscode modules #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
changed the title
|
Testing:
|
glennsarti
changed the title
|
This is technically #337 not a maint commit... |
jpogran
suggested changes
Oct 11, 2018
This commit updates the vscode-languageclient node module to 4.4.0. This is needed for more recent LSP features.
This commit updates the vscode-languageclient node module to 5.1.0. This is needed for more recent LSP features.
Previously the vscode module was only using an older vscode npm module however this had some security vulnerabilites. This commit forces npm to use the latest module in the 1.x series.
glennsarti
force-pushed
the
spike-update-lang-client
branch
from
f3eeee9 to
4a61a9a
Compare
|
@jpogran Commit messages modified. |
glennsarti
changed the title
jpogran
approved these changes
Oct 12, 2018
| import { PuppetStatusBar } from "./PuppetStatusBar"; | ||
| import { ILogger } from "./logging"; | ||
| import { ServerOptions, LanguageClientOptions } from "vscode-languageclient/lib/client"; | ||
| import { LanguageClientOptions } from "vscode-languageclient/lib/client"; |
There was a problem hiding this comment.
Nit: this can be one line if you remove lib/client. This can be done in a new PR
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the vscode-languageclient node module to 5.1.0. This is
needed for more recent LSP features.
This is in two commits so you can see the progression as the extension takes on major version bumps in the node module.
This also updates the vscode dev dependency to remove security vulnerabilities and to get any bug fixes.
Fixes #337