(#4388) Remove the dead authconfig setting#1203
Closed
nfagerlund wants to merge 87 commits intopuppetlabs:3.xfrom
Closed
(#4388) Remove the dead authconfig setting#1203nfagerlund wants to merge 87 commits intopuppetlabs:3.xfrom
authconfig setting#1203nfagerlund wants to merge 87 commits intopuppetlabs:3.xfrom
Conversation
As DragonFly is an offspring of FreeBSD, most of the assumptions for FreeBSD are valid for DragonFly BSD. The only notable exception is package management, which is performed using pkgin. While implementing, a missing function in the FreeBSD service provider has been noted.
* 3.x: (#15940) Add test coverage for rdoc exclude option (#15853) Update gem dependencies to reflect rc ordering (#15940) Update puppet doc to ignore files and templates in modules (puppetlabs#7442) solaris: return "-1" for password_max_age when password aging is disabled (puppetlabs#7442) solaris: add tests for password_max_age attribute
* 3.x: (Maint) Add logging for when Puppet is enabled/disabled.
* 3.x: (#15346) Add spec test for --source when checking latest (#15346) add --source to the gem list command (#11870) Add compatibility with recent Solaris changes (Maint) Add logging for when Puppet is enabled/disabled. (#11870) Manage executable packages on Windows (#11870) Refactor package management logic for MSI (#11870) Deprecate the `:msi` provider (#11870) Add the ability to specify uninstall_options (#11870) Refactor the MSI provider to use package options Don't issue deprecation warnings for allow_ip (#15521) Convert to using host stub wrapper (#11870) Add package options parameter (#11870) Refactor windows-specific requires (#11870) Add registry module (Maint): Re-enable tests on Windows
* upstream/3.x: (#11870) Pass a list of Arrays to multiple_yields (Maint) Fix assertion about locale to correct value.
* upstream/3.x: (#11870) Ignore uninstall keys that don't exist (Maint) Include the registry key path in the exception
* 3.x: Fix missing forge stub and directory check due to test change in 3.x branch rollup
* 3.x: Add rake task to regenerate parser Test that facts preserve case (#15762) Clean up `reload_facter` method (#15752) Remove references to ca_days (#15771) Remove deprecations in Type objects (#15769) Remove `type` attribute for package (#15762) Remove support for Facter versions below 1.5.5 (#15763) Remove `mkmodelmethods` method (#15755) Remove `set_default_format` method (#15753) Remove `reportserver` setting (#15751) Remove `--apply` option (#15765) Raise error for invalid values for recurse parameter (#15760) Require $ on variables in definitions (#15766) Remove 'path' as a valid parameter for the mount point (#15765) Don't allow setting recursion depth with `recurse` (#15758) Remove fact downcasing (#15750) Remove setting `cacrl` to false (#15752) Remove ca_days (#15852) Remove version check from puppet_spec.rb (#15852) Allow rc in Puppet and Facter version strings
* upstream/3.x: (#16042) Remove deprecated Functions methods (#15912) Make function access consistent (Maint) Skip crontab filetype tests on Windows Update CHANGELOG, conf/redhat/puppet.spec for 2.7.19rc3 (#14283) Call Tempfile#close and #unlink separately (#14283) Raise an error when crontab returns non-zero on AIX (maint) Refactor filetype specs (maint) Consolidate flat file tests (maint) Remove spurious `puts` line (maint) Whitespace cleanup (maint) Include backtrace in re-raised exception Ruby 1.9.3 has a different error when `require` fails. (#15291) Add Vendor tag to Puppet spec file (#14283) Fix suntab filetype when run as normal user maint: Refactor suntab and aixtab filetype Add packaging support for fedora 17
* upstream/3.x: Revert "Merge branch 'ticket/2.7.x/15464_a_gemfile_would_improve_contributor_on-boarding' into 2.7.x" (#15464) Make Puppet.version settable via Puppet.version= (#15693) Allow restart command to be specified (#15464) Make Puppet usable as a Gem from source Move Puppet version into lib/puppet/version.rb (#15464) Make contributing easy via bundle Gemfile (Maint) Fix rspec options file
* 3.x: (#15464) Exclude gem command from bundler Revert "Revert "Merge branch 'ticket/2.7.x/15464_a_gemfile_would_improve_contributor_on-boarding' into 2.7.x"" (#15975) Extract HTTP methods from REST Indirector
* 3.x: (Maint) Fix Puppet.version in 3.x (puppetlabs#8200) Change path from parameter to property (puppetlabs#8200) Munge the ensurable value (Maint) Update the test cases to use the 'let' (puppetlabs#8200) Ensure zonecfg errors are caught (#15547) correct 'pending' values to correct if check for solaris.
* 3.x: (#15975) Add missing methods to new HTTP::Connection class
* 3.x: (#15975) Proxy the request_get block to Net::HTTP (Maint) Fix Puppet::Util.execute warning
* 3.x: (#15797) Disable RedHat services in all run levels (Maint) Whitespace only cleanup (#15797) Add test coverage for redhat service provider (#15797) Change the argument to chkconfig from 'on' to 'reset' Update CHANGELOG, conf/redhat/puppet.spec for 2.7.19 Fix typo in create_resources function's description string
* 3.x: (#15975) Add tests for http methods that accept blocks
* upstream/3.x: (puppetlabs#7788) Rely on Rubygems caching of directories (puppetlabs#7788) Extend Puppet using rubygems
* upstream/3.x: (puppetlabs#7788) Cache paths from older rubygem versions (puppetlabs#7986) check if pkg is the default provider for opensolaris (puppetlabs#7986) make solaris pkg versionable. (Maint) : fix the jenkins failure for setconfig
The test for the message emitted for calling an incorrect action on a face sometimes fails because it sees "Could not run Puppet configuration client: Not a directory - /dev/null/state/agent.pid" instead. This changes the way the assertion is done so that the test failure will provide more information about what else is in the log at the time of the failure, which might help in tracking down what is going wrong.
* upstream/3.x: (Maint) Remove dependency on Facter 2.0
* 3.x: (29 commits) Add a terminus setting type (#16058) Set pson as default catalog cache format (#16058) Add setting to configure catalog cache (#15193) Fix StaticCompiler#store_content (#15193) Add spec test coverage for static compiler Document the different forms of catalogs to help test writers (#15193) Document how to use the static compiler (Maint) Stop watchr from reading non-existent spec.opts Whitespace only cleanup Update CHANGELOG, version.rb, redhat.spec for 3.0.0rc5 Maint: Use pending block maint: remove .rspec entirely Maint: Make paths absolute on Windows (#16137) Delay evaluation of config and var directories (Maint) Enable colorized rspec output on Windows (#16137) Tilde expansion should only occur for normal users (Maint) Remove trailing whitespace (#16137) Ensure HOME is set before attempting ~ expansion Move singleton require to puppet/util/storage.rb (#15739) Bump report_version since #10064 change its format ... Conflicts: lib/puppet/settings.rb
* 3.x: (#15193) Fix windows failing on unix style paths
Conflicts: lib/puppet/provider/service/init.rb spec/integration/provider/service/init_spec.rb spec/integration/type/package_spec.rb Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>
Fix a small docs typo - umounted vs. unmounted
* 3.x: (Maint) Make puppet module install --confdir=foo puppetlabs-stdlib work
* 3.x: (Maint) Add test coverage for --confdir=/tmp/puppet patch (#15190) Avoid deprecated iconv on Ruby 1.9
* 3.x: (Maint) Add tests of passing undef as parameter. (#16144) Update puppet spec file for fedora 17 and systemd changes systemd unit files added on own branch for pull request to satisfy issue 16144 : https://projects.puppetlabs.com/issues/16144
* upstream/3.x: Disable ActiveSupport::Dependencies hooks. zaml: handle multi-line map keys and array values correctly. zaml: don't use backreferences on strings zaml: avoid calling emit when we don't have anything to output zaml: add whitespace for readability. zaml: rework strings for correctness and speed Maint: Fix intermittently failing spec test zaml: unify on a single definition of `to_zaml` for Symbol zaml: statically determine the to_ascii8bit implementation. Use `intern` rather than `symbolize` it Puppet::Type Implement Symbol#intern when it is missing. Add catalog JSON terminus to improve performance. Implement a JSON file terminus to mirror YAML.
* upstream/3.x: (maint) add hiera to ext/envpuppet path and libpath (maint) use described_class.new for getting the provider instance. (maint) convert user_role_add_spec to the new format of writing test cases. Implement `Fixnum#ord` for Ruby 1.8.5 tagging: use a static regexp rather than rebuilding it file_serving: avoid rewriting paths if possible. log_paths: memoize the entire value, not just part of it. zaml: speed micro-optimization for Time output whit: cache the `to_s` result. zaml: don't sort object attributes for output util: don't rebuild regexp every time we invoke absolute_file? parser/files: use a cheaper test for "is this path absolute?" Eliminate remaining uses of FileCollection. FileCollection is a memory loss, not a memory win. type: support implicit "identity" transformation monkey_patch: cache Symbol to_proc result. lexer: remove some unused stats collection tagging: document why fixing this horror is hard. type: memoize key_attributes for types. Avoid object creation/destruction when possible.
* 3.x: (puppetlabs#7316) Load applications from the modulepath Update puppet.spec.erb to correct rpmlint issues
* 3.x: (Maint) Fix spec failures with Puppet::Face[]
* 3.x: Revert "Merge branch 'fix/3.x/fix_puppet_face_failures' into 3.x" Revert "Merge branch 'fix/3.x/7316_load_faces_from_modulepath' into 3.x"
* upstream/3.x: Update debian ruby dependencies to include 1.9 Add --ruby flag to install.rb (#13435) Use new digest code when generating a CSR (#13435) Use digest algorithm from CSR for fingerprint Replace Config::CONFIG with RbConfig::CONFIG Remove sbin references from install.rb Remove CHANGELOG file Update docs w/ new default logoutput value from ticket #10907 Update puppet.spec, bump required ruby to 1.8.7 Set ca_location in ca face
* 3.x: Pass wrapped real scope to DataBinding Updating lib/puppet/version.rb for 3.0.0-rc7 Removing hiera-puppet dependency from project_defaults (#13435) Use SHA256 for puppet agent --fingerprint (#13435) Convert digest to string in cert interface Remove svn specific code from install.rb Remove references to CHANGELOG in packaging
* 3.x: (maint) Fix Failed to load face errors (#15214) Remove confdir and vardir from run_mode Revert "Merge branch 'revert/3.x/faces_from_modulepath' into 3.x"
* 3.x: Extract methods from set_default_parameters and improve test coverage (#16221) Make undef not override default parameters
* upstream/3.x: Revert "Merge branch 'fix/3.x/7316_load_faces_from_modulepath_try3' into 3.x"
* 3.x: (#16567) Remove :lexical setting default Stub DataBinding in undef param tests Revert "Merge branch 'fix/3.x/7316_load_faces_from_modulepath_try3' into 3.x"
* 3.x: (Maint) Remove rspec from shebang line Update description of HTTP/HTTPS report Updating PUPPETVERSION for 3.0.0-rc8 Update default cows and mocks
…_try3' into 3.x"" This reverts commit ef3fe69.
…pp_defaults Without this patch we don't have any spec test coverage for the app_defaults instance method of the Puppet::Application::Master class. This lack of coverage is problem because cherry picking the confdir and vardir patch from PR-882 in commit b064ee6 appears to work just fine after resolving the merge conflicts. Things were not fine, however, because the app_defaults method makes a call that raises an exception and none of our spec tests caught this issue. The acceptance tests did, however, by exercising the command `puppet master --configprint pidfile`
… the master Without this patch applied `puppet master` will explicitly set the value for confdir and vardir inside of Puppet::Application::Master#app_defaults. This is a problem because it calls a method that does not exist while trying to do so. This patch fixes the problem by implementing the intended behavior documented in #15337, and specifically in commit 38cba0a. This intended behavior is: 1: If provided, use explicit puppet.conf in `--confdir` 2: If root, use system puppet.conf 3: Otherwise, use ~/.puppet/puppet.conf
* 3.x: sample_module.pp refactored text: include sample-module into include sample_module This will fix Refactor #16643. Update lib/puppet/version.rb for 3.0.0
The parser for config files used to be tied up with all of the other logic for handling configuration settings. This takes the first step in encapsulating that parsing into a class that is dedicated to just parsing a configuration file.
This extracts the config file parsing into its own class so that is can be worked with independently of the rest of the settings system.
This adds coverage for, I think, all of the config file structure parsing behavior. Since the value transformations are not currently part of this parsing code, they are not taken into account.
…p-settings (Maint) Split out config file parsing
…ad_faces_from_modulepath_try4 (puppetlabs#7316) Do not set default values for confdir and vardir in the master Conflicts: lib/puppet/settings.rb Merge conflict config file parsing related to a disallowed section replicated in the config_file.rb parser.
The main loop of parsing the config file has a lot of error handling directly in it. This makes it harder to follow the main flow and less obvious what it is doing. This pulls out some of that checking and removes duplication around creating a new section.
As of commit 4b6db1c or so, this setting is no longer referenced anywhere in the Puppet code. It used to point to the namespaceauth.conf file, which we no longer consult for any purpose. The setting should go away.
Contributor
Author
|
Whoops, looks like you can't retarget a pull request. KILL NOW. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of commit 4b6db1c or so, this setting is
no longer referenced anywhere in the Puppet code. It used to point to the
namespaceauth.conf file, which we no longer consult for any purpose. The setting
should go away.