(#22557) Raise an error providing a package resource with multiple names

[jpartlow]

Redmine #22557 brought up a regression in package provider behavior
(specifically dpkg). Previously it was possible, under some
circumstances to supply a package resource with an array for the name
attribute, and have puppet manage the set of packages. However, this
was an accidental feature which could fail if some packages were in
different states because the providers' query methods ultimately operate
on the package property hash info of just one of the packages.

This commit makes explicit that a package resource should not have its
name attribute set to an array of more than one value, and will raise a
ResourceError if this is attempted.

[puppetcla]

CLA signed by all contributors.

[joshcooper]

@jpartlow this change will work for package providers in core, but not modules, e.g. https://github.com/bjoernalbers/puppet-homebrew/blob/master/lib/puppet/provider/package/homebrew.rb#L47-L49. I'm not sure if we care?

From what I can tell the Puppet::Provider::Package#query method is only called by the #properties method in the same class. We could create a new query method that does the validate check:

def query_wrapper
  validate_resource
  query
end

def properties
  if @property_hash.empty?
    @property_hash = query_wrapper || {:ensure => :absent}

and then leave the core & custom package providers as they were?

[zaphod42]

Superseded by GH-1980