(#22557) Validate that a package name is a string#1980
Merged
jpartlow merged 1 commit intopuppetlabs:masterfrom Oct 8, 2013
Merged
Conversation
The package providers assume that the name of a package resource is a string, but the type allowed the name to be anything. This caused some manifests to pass several different names in and rely on an accident of the provider implementation that allowed that to work in some situations. Since the providers were never intended to work with multiple names, this changes the type to validate that the name is simply a string.
|
CLA signed by all contributors. |
jpartlow
added a commit
that referenced
this pull request
Oct 8, 2013
…ray-of-package-names-not-allowed (#22557) Validate that a package name is a string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package providers assume that the name of a package resource is a string,
but the type allowed the name to be anything. This caused some manifests to
pass several different names in and rely on an accident of the provider
implementation that allowed that to work in some situations. Since the
providers were never intended to work with multiple names, this changes the
type to validate that the name is simply a string.