(maint) Allow factset hashes to be null in db#1140
Merged
kbarber merged 1 commit intopuppetlabs:masterfrom Nov 5, 2014
Merged
Conversation
|
Test PASSed. |
wkalt
force-pushed
the
maint/make-factset-schema-nullable
branch
from
c8af968 to
9d11208
Compare
|
Test PASSed. |
Contributor
Author
Contributor
There was a problem hiding this comment.
Instead of modifying an already existing test, can we make a point minimalistic test for this case and make it its own unit test in that way?
This is necessary for factsets to function after the PDB-898 migration, since existing factsets are not being hashed.
wkalt
force-pushed
the
maint/make-factset-schema-nullable
branch
from
9d11208 to
04d2a86
Compare
Contributor
Author
|
@kbarber fixed |
Contributor
|
+1, waiting for tests |
|
Test PASSed. |
kbarber
added a commit
that referenced
this pull request
Nov 5, 2014
(maint) Allow factset hashes to be null in db
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary for factsets to function after the PDB-898 migration,
since preexisting factsets are not being hashed.