WIP: [PE-6474] This fix adds support for classes with hyphens in the name.#1149
WIP: [PE-6474] This fix adds support for classes with hyphens in the name.#1149llowder wants to merge 1 commit intopuppetlabs:1.6.xfrom
Conversation
This will enable full compatibiity with Puppet 3.x, which still allows classes to have hyphens in the names
|
Can one of the admins verify this patch? |
|
Hyphens in classnames are not supported in Puppet 4.0 and has issues in 3x. So, is this really needed? |
|
@hlindberg It's to enable a large customer to upgrade off of 2.8 in a reasonable timeframe. We can talk offline if you'd like. |
|
After talking with @llowder I think this is harmless (there is probably no risk that those hyphens will come back and haunt a 4.0 system after an upgrade), and of great value in helping customers transition to 3x. |
There was a problem hiding this comment.
This will allow trailing hyphens. Is that legal?
There was a problem hiding this comment.
@nicklewis Probably about as legal as hyphens in general. The allowance of them and where has never been well defined, even during the brief time when they were officially allowed. For most versions of puppet, behavior when it comes to hyphens has been undefined.
There was a problem hiding this comment.
I would not be surprised if one of the wacky "lets allow hyphens" versions also allowed a hyphen last...
|
This ticket number doesn't match what's in Jira. |
|
@kbarber There are 3 different tickets involved - an escalation ticket, a public ticket and a private one. If the number here doesn't match any of those, it's possible I got them mixed up by mistake. |
|
@pljenkinsro retest this please |
|
Test FAILed. |
|
@pljenkinsro retest this please |
|
oh, didn't see that this is against 1.6.x -- that's the reasons for the failures |
|
Test FAILed. |
|
@llowder We don't have any plan to have any more 1.6.x releases, should this be targeted at stable instead? If you have some time on Monday or Tuesday we should work through some tests. |
|
@llowder ping |
kbarber
changed the title
|
Can one of the admins verify this patch? |
|
@llowder I imagine you're busy, but when you have the time, can you take a look at the comments on this PR? |
|
Can one of the admins verify this patch? |
|
Closing for now (since it will need to change branch anyway ...), please re-open on the correct branch when you are ready @llowder. |
7 participants
This will enable full compatibiity with Puppet 3.x, which still allows
classes to have hyphens in the names