(maint) fix puppetdb-env.erb so it generates valid bash

[wkalt]

There is a bug affecting some OSes where this template will miss a necessary newline in the bash it generates. An example is here:

https://gist.github.com/wkalt/fe8949ea40eb95c3aa9b

note that JAVA_BIN and INSTALL_DIR are on the same line

[pljenkinsro]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/459/

[ajroetker]

I don't think we use that file in our packaging any more? I'm not sure about stable though.

[wkalt]

@ajroetker yeah affects stable. A customer raised it on PE 3.3.1.

[kbarber]

Hrm ... not sure this is going to be a problem or not, I think we should keep quoting stuff where we were before. Should be only the unquoted elements that were a problem before. Perhaps even considering quote JAVA_BIN now ... for example this won't handle spaces in the file paths I think.

[wkalt]

@kbarber fixed

[pljenkinsro]

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/485/

[rbrw]

@pljenkinsro retest this please

[pljenkinsro]

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/488/

[rbrw]

@pljenkinsro retest this please

[pljenkinsro]

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/490/

[rbrw]

@pljenkinsro retest this please

[pljenkinsro]

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/491/

[rbrw]

@pljenkinsro retest this please

[pljenkinsro]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/493/