(maint) Remove redirect to PuppetDB dashboard#1380
Closed
ajroetker wants to merge 1 commit intopuppetlabs:masterfrom
Closed
(maint) Remove redirect to PuppetDB dashboard#1380ajroetker wants to merge 1 commit intopuppetlabs:masterfrom
ajroetker wants to merge 1 commit intopuppetlabs:masterfrom
Conversation
This commit changes the PuppetDB dashboard to be served as a file response on "/" explicitly instead of a redirect to "/dashboard/index.html". This allows us to refrain from passing url-prefix to the main PuppetDB app `routes` function, as well as modularizing the dashboard to its own handler so it can be served separately from the PuppetDB query app.
Contributor
Author
|
Just something that occurred to me might be nice for our dashboard while going through an |
|
Test PASSed. |
Contributor
Author
|
Closing as it complicates existing work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the PuppetDB dashboard to be served as a file
response on "/" explicitly instead of a redirect to
"/dashboard/index.html". This allows us to refrain from passing
url-prefix to the main PuppetDB app
routesfunction, as well asmodularize the dashboard to its own handler so it can be served
separately from the PuppetDB query app.