Skip to content

(maint) Update tests to use new Facter 3 variables#1491

Merged
wkalt merged 2 commits intopuppetlabs:stablefrom
kbarber:maint/stable/fix-tests-for-facter-3
Jun 25, 2015
Merged

(maint) Update tests to use new Facter 3 variables#1491
wkalt merged 2 commits intopuppetlabs:stablefrom
kbarber:maint/stable/fix-tests-for-facter-3

Conversation

@kbarber
Copy link
Copy Markdown
Contributor

@kbarber kbarber commented Jun 25, 2015

Signed-off-by: Ken Barber ken@bob.sh

@pljenkinsro
Copy link
Copy Markdown

pljenkinsro commented Jun 25, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1540/

@kbarber
Copy link
Copy Markdown
Contributor Author

kbarber commented Jun 25, 2015

@pljenkinsro retest this please

@kbarber kbarber added the work in progress (...and please don't merge) label Jun 25, 2015
@kbarber
Copy link
Copy Markdown
Contributor Author

kbarber commented Jun 25, 2015

On second glance most of that older debian 6 & ubuntu 10 JDK stuff can go, I'm going to update this patch.

@pljenkinsro
Copy link
Copy Markdown

pljenkinsro commented Jun 25, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1541/

@kbarber
(maint) Update tests to use new Facter 3 variables
792bc31 
This changes us to be Facter 3 compatible in the tests, also removing some
older Debian 6 & Ubuntu 10 stuff.

Signed-off-by: Ken Barber <ken@bob.sh>
@kbarber kbarber force-pushed the maint/stable/fix-tests-for-facter-3 branch from 8872e16 to 792bc31 Compare June 25, 2015 16:36
kbarber
kbarber reviewed Jun 25, 2015
View reviewed changes
acceptance/setup/pre_suite/40_install_deps.rb
Copy link
Copy Markdown
Contributor Author

@kbarber kbarber Jun 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all dead stuff, we don't test on systems that don't have JDK7 any more (not for the stable & master branches anyway).

@pljenkinsro
Copy link
Copy Markdown

pljenkinsro commented Jun 25, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1543/

@kbarber
Rename ubuntu 12.04 image name to remove dot
9b33dbc 
Puppet didn't like the dot in our ubuntu 1204 hostname for the 3 box test,
this removes the dot.

Signed-off-by: Ken Barber <ken@bob.sh>
@pljenkinsro
Copy link
Copy Markdown

pljenkinsro commented Jun 25, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1544/

wkalt added a commit that referenced this pull request Jun 25, 2015
@wkalt
Merge pull request #1491 from kbarber/maint/stable/fix-tests-for-fact…
3722d69 
…er-3

(maint) Update tests to use new Facter 3 variables
@wkalt wkalt merged commit 3722d69 into puppetlabs:stable Jun 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

work in progress (...and please don't merge)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kbarber @pljenkinsro @wkalt