(PDB-5466) Allow database config passwords to be INI integers#3649
Closed
stelcodes wants to merge 2 commits intopuppetlabs:6.xfrom
Closed
(PDB-5466) Allow database config passwords to be INI integers#3649stelcodes wants to merge 2 commits intopuppetlabs:6.xfrom
stelcodes wants to merge 2 commits intopuppetlabs:6.xfrom
Conversation
Adds clojure.lang.str as a type coercion function when trying to coerce a value to java.lang.String
This allows the user to specify database passwords with unquoted numbers in their PDB INI config. Previously this would throw a fatal exception because our input schema expected only strings. Now our input schema expects a string or an integer for database password and migrator-password.
Contributor
Author
|
We are not going to merge this patch because the translation from integer to string may be lossy (ex +100 -> "100") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tickets.puppetlabs.com/browse/PDB-5466