Conversation
|
💚 Test passed. |
|
CLA signed by all contributors. |
project.clj
Outdated
There was a problem hiding this comment.
Should this be bumped to 0.1.0 release of trapperkeeper?
There was a problem hiding this comment.
Agh! good catch. I got the ones in the normal dependencies section but I always forget the test ones :(
|
Other than the two minor things I pointed out, looks good! I like the namespaced keywords for the error types. |
|
SNAPSHOT test dependency is fixed. Will wait to hear response on the github docs link before making any changes there. |
|
💚 Test passed. |
|
💚 Test passed. |
Conflicts: project.clj src/com/puppetlabs/puppetdb/cli/services.clj src/com/puppetlabs/puppetdb/config.clj test/com/puppetlabs/puppetdb/fixtures.clj test/com/puppetlabs/puppetdb/test/config.clj
This commit does the following: * Introduces a `context` atom in services.clj, whose value is a map used to keep references to the various stateful bits of the PuppetDB subsystems. This is something that has been discussed previously as a means for potentially allowing more interactive development in the REPL, and for doing things like dynamically reloading subsystems when configuration changes occur. In this commit, it's used to provide a way to shutdown those subsystems when a fatal error occurs. * Adds the new `error-shutdown!` function, which is responsible for shutting down threads and subsystems from the `context` when a fatal error has occurred.
By default, leinengen doesn't allow SNAPSHOT dependencies when running `uberjar` on a project that is not also a SNAPSHOT. Because of the way that we handle the project version in the PuppetDB project.clj file, PuppetDB is *never* in a SNAPSHOT state. This commit adds an environment variable that will cause leinengen to allow SNAPSHOT deps, but only when running acceptance tests FROM SOURCE. Packaging jobs should still fail if this kind of scenario is encountered for now.
This commit does the following: * Update to a released version of trapperkeper * Update to a released version of kitchensink * Change cli error handling to use new namespaced keywords
Web server configuration is now handled by trapperkeeper. Conflicts: src/com/puppetlabs/puppetdb/config.clj
|
@kbarber @grimradical @senior OK, this is rebased. |
|
🔴 Test failed. |
|
🔴 Test failed. |
|
@puppetlabs-jenkins retest this please |
|
💚 Test passed. |
…-to-trapperkeeper Refactor to trapperkeeper
6 participants
This PR is a replacement for #773. It is rebased onto the latest PuppetDB master branch, updated to use released versions of trapperkeeper and kitchensink, and addresses all of the comments that were made on that PR.