PDB-249 commands config exceptions#782
Merged
senior merged 2 commits intopuppetlabs:masterfrom Jan 3, 2014
Merged
Conversation
The use of (s/maybe s/Int) for the configuration options store-usage and temp-usage were throwing exceptions when these configuration options were used. So this is really a bug in the convert-schema support, but in our case we don't need to support the concept of 'nil' or 's/Int' for these items (which is what s/maybe effectively does) since they are already marked as optional. This patch removes the use of s/maybe removing the exception, but does not fix the original bug. Signed-off-by: Ken Barber <ken@bob.sh>
… types Previously for types schema.core.Predicate the function get-construct-fn was failing as there was no support. This patch extends the PredicateConstructFn protocol to support these types by simply passing through the value without coercion or change. Signed-off-by: Ken Barber <ken@bob.sh>
Contributor
|
💚 Test passed. |
senior
added a commit
that referenced
this pull request
Jan 3, 2014
…onfig-exceptions PDB-249 commands config exceptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes PDB-249, whereby the usage of the options store-usage and temp-usage was throwing exceptions in configuration.
More details in the individual commits.