PDB-307 Fix private method rspec failures due to mocha 1.0.0 upgrade#798
Merged
senior merged 2 commits intopuppetlabs:1.5.xfrom Jan 14, 2014
Conversation
This patch fixes an rspec failure we were having on the terminus due to the recent bump from mocha from 0.14.1 to 1.0.0. Previously mocha seems to have been ignoring private method calls for whatever reason. With the new version of mocha it is throwing exceptions (as it rightly should). This patch removes the use of the `private` declaration and converts all of these methods to be document `@api private` in YARD instead migrating a language enforcement to a documentation enforcement instead. As an aside I noticed that char_encoding.rb had a 3 space indent convention, this has been converted to 2 space as per our standard. Signed-off-by: Ken Barber <ken@bob.sh>
This patch moves the jenkins rspec build script into our git repository to be called by jenkins instead of loading up the full script in the job itself. Signed-off-by: Ken Barber <ken@bob.sh>
Contributor
|
💚 Test passed. |
Contributor
|
💚 Test passed. |
senior
added a commit
that referenced
this pull request
Jan 14, 2014
…_method_rspec_failures PDB-307 Fix private method rspec failures due to mocha 1.0.0 upgrade
|
CLA signed by all contributors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes an rspec failure we were having on the terminus due to the
recent bump from mocha from 0.14.1 to 1.0.0.
Previously mocha seems to have been ignoring private method calls for whatever
reason. With the new version of mocha it is throwing exceptions (as it rightly
should).
This patch removes the use of the
privatedeclaration and converts all ofthese methods to be document
@api privatein YARD instead migrating alanguage enforcement to a documentation enforcement instead.
As an aside I noticed that char_encoding.rb had a 3 space indent convention,
this has been converted to 2 space as per our standard.
Signed-off-by: Ken Barber ken@bob.sh