Invalid namespaces for tests http/nodes|fact_names masking failures#829
Merged
senior merged 1 commit intopuppetlabs:1.6.xfrom Feb 5, 2014
Merged
Conversation
The test files http/fact_names.clj and nodes.clj had incorrect namespace declarations that were overridden in other files. This caused these tests to be skipped and in fact mask a couple of failures. Luckily these were testing failures only, once fixed this is all passing again. Signed-off-by: Ken Barber <ken@bob.sh>
Contributor
|
💚 Test passed. |
|
CLA signed by all contributors. |
senior
added a commit
that referenced
this pull request
Feb 5, 2014
Invalid namespaces for tests http/nodes|fact_names masking failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test files http/fact_names.clj and nodes.clj had incorrect namespace
declarations that were overridden in other files. This caused these tests
to be skipped and in fact mask a couple of failures.
Luckily these were testing failures only, once fixed this is all passing
again.
Signed-off-by: Ken Barber ken@bob.sh