(maint) Replace shell logic for OS release with Facter#883
Merged
kbarber merged 1 commit intopuppetlabs:1.6.xfrom Mar 11, 2014
mckern:1.6.x
Merged
(maint) Replace shell logic for OS release with Facter#883kbarber merged 1 commit intopuppetlabs:1.6.xfrom mckern:1.6.x
kbarber merged 1 commit intopuppetlabs:1.6.xfrom
mckern:1.6.x
Conversation
To generate the correct init script components, install.rake was shelling out to get a static field from /etc/redhat-release. This is a fragile technique and Facter uses a much more robust technique to derive the correct value across numerous RPM-based platforms. This technique was part of the 1.7.x Facter branch, so a build-time dependency has been added on Facter 1.7.0 or greater.
|
Can one of the admins verify this patch? |
Contributor
|
👍 |
kbarber
added a commit
that referenced
this pull request
Mar 11, 2014
(maint) Replace shell logic for OS release with Facter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To generate the correct init script components, install.rake
was shelling out to get a static field from /etc/redhat-release.
This is a fragile technique and Facter uses a much more robust
technique to derive the correct value across numerous RPM-based
platforms. This technique was part of the 1.7.x Facter branch,
so a build-time dependency has been added on Facter 1.7.0 or greater.