Skip to content

(PDB-452) Adding support for storing environments#894

Merged
kbarber merged 2 commits intopuppetlabs:masterfrom
senior:ticket/master/pdb-452-support-environments-in-commands
Mar 25, 2014
Merged

(PDB-452) Adding support for storing environments#894
kbarber merged 2 commits intopuppetlabs:masterfrom
senior:ticket/master/pdb-452-support-environments-in-commands

Conversation

@senior
Copy link
Contributor

@senior senior commented Mar 24, 2014

Added support for environments to the model and command wire formats.

@senior
Copy link
Contributor Author

senior commented Mar 24, 2014

This will need to be rebased after #890 gets merged up into master. There will be one conflict over the "next" migration to run.

@pljenkinsro
Copy link

pljenkinsro commented Mar 24, 2014

🔴 Test failed.
Refer to this link for build results: https://jenkins.puppetlabs.com/job/PuppetDB%20Acceptance%20-%20Pull%20Requests/304/

@pljenkinsro
Copy link

pljenkinsro commented Mar 24, 2014

💚 Test passed.
Refer to this link for build results: https://jenkins.puppetlabs.com/job/PuppetDB%20Acceptance%20-%20Pull%20Requests/305/

@kbarber
Copy link
Contributor

kbarber commented Mar 25, 2014

@senior this can be rebased now.

(PDB-452) Adding support for storing environments
2585409 
Added support for environments to the model and command wire formats.
@senior
Copy link
Contributor Author

senior commented Mar 25, 2014

Done

kbarber
kbarber reviewed Mar 25, 2014
View reviewed changes
documentation/api/wire_format/catalog_format_v4.markdown
Copy link
Contributor

@kbarber kbarber Mar 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has api-version been dropped as well?

Copy link
Contributor Author

@senior senior Mar 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the entire metadata object that contained the api_version as well, pulling up the "data" value to the top level object.

Copy link
Contributor

@kbarber kbarber Mar 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth a mention explicitly.

@pljenkinsro
Copy link

pljenkinsro commented Mar 25, 2014

💚 Test passed.
Refer to this link for build results: https://jenkins.puppetlabs.com/job/PuppetDB%20Acceptance%20-%20Pull%20Requests/307/

kbarber
kbarber reviewed Mar 25, 2014
View reviewed changes
documentation/api/wire_format/catalog_format_v1.markdown Outdated
Copy link
Contributor

@kbarber kbarber Mar 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs highlighting somewhere like in other files "> Note: "

@pljenkinsro
Copy link

pljenkinsro commented Mar 25, 2014

🔴 Test failed.
Refer to this link for build results: https://jenkins.puppetlabs.com/job/PuppetDB%20Acceptance%20-%20Pull%20Requests/309/

@kbarber
Copy link
Contributor

kbarber commented Mar 25, 2014

Error was transient. Merging.

kbarber added a commit that referenced this pull request Mar 25, 2014
@kbarber
Merge pull request #894 from senior/ticket/master/pdb-452-support-env…
343ac39 
…ironments-in-commands

(PDB-452) Adding support for storing environments
@kbarber kbarber merged commit 343ac39 into puppetlabs:master Mar 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@senior @pljenkinsro @kbarber