WIP (maint) have beaker tests use the host.hostname instead of host.name#910
WIP (maint) have beaker tests use the host.hostname instead of host.name#910anodelman wants to merge 1 commit intopuppetlabs:masterfrom anodelman:beaker-vm-hostname-mismatch
Conversation
- when you want the current hostname use host.hostname, for some provisioners host.name is the name provided by the user but the current hostname is generated on the fly and thus different.
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
@anodelman does this work when using vagrant? BTW ... I'm already pinning against a branch of beaker I'm waiting to get merged in due to an issue I had to fix relating to EC2 zombies. So we can't then pin against this as well, I'd rather we got a real release if possible. |
kbarber
changed the title
|
@anodelman also, vmhostname doesn't get populated in our main provider blimper.rb either. Will this just break in this case, or is the fallback to name enough? |
|
@anodelman btw, this will need targeting at 1.5.x anyway, can you re-aim this PR at that branch? |
|
@anodelman hiya, any comments on my comments? I think this will need retargeting for another branch anyway (1.5.x), since we usually target testing changes at all our active branches. Re-open when you're ready. |
|
@kbarber sorry, missing these comments. What branch do you want this targeted against? This will continue to work with blimpy/your ec2 support as you rename the box - so it defaulting to host[:name] will be correct. |
3 participants
provisioners host.name is the name provided by the user but the
current hostname is generated on the fly and thus different.
This will depend on voxpupuli/beaker#205 landing and being rolled into a gem - we may want to pin to a beaker version to ensure that this works once the update rolls out.