Ticket/master/pdb 467 merge versioned http tests#966
Merged
senior merged 3 commits intopuppetlabs:masterfrom May 27, 2014
Merged
Conversation
|
🔴 Test failed. |
Contributor
Author
|
@pljenkinsro retest this please |
|
🔴 Test failed. |
This patch removes all remaining versioned http test files into shared unversioned files, so that we may start iterating across versions in the same file. Signed-off-by: Ken Barber <ken@bob.sh>
This patch creates deftestseq which really is just a combination of deftest and Ryan's doseqver. This has been implemented across all http tests now as a standard for iterating across each available API version for that particular end-point. All cases of :use have been moved into their relevant :require sections for all these tests as well, including some other various cleanups. Signed-off-by: Ken Barber <ken@bob.sh>
|
💚 Test passed. |
Contributor
There was a problem hiding this comment.
It's good to see this moved out
Contributor
|
I have 2 very minor comments, other than those, I'm a +1 |
Also remove one commented end-point. Signed-off-by: Ken Barber <ken@bob.sh>
|
💚 Test passed. |
Contributor
Author
|
@senior amended based on your two comments. |
senior
added a commit
that referenced
this pull request
May 27, 2014
…ioned-http-tests Ticket/master/pdb 467 merge versioned http tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.