Skip to content

Conversation

@DavidS
Copy link
Contributor

@DavidS DavidS commented Nov 25, 2019

This PR was created using this script in stages running pdk update and committing individual changes in multiple iterations. Some manual fixes interspersed to reduce aberrations.

#! /usr/bin/ruby
require 'yaml'

contents = YAML.load(File.read(".sync.yml"))

contents[".gitlab-ci.yml"] = {'delete' => true}
contents["spec/spec_helper.rb"] ||= {}
contents["spec/spec_helper.rb"]['coverage_report'] = true

gitignore = contents[".gitignore"] ||= {}
gitignore["required"] ||= []
gitignore["required"] -= ["---.project"]
gitignore.delete("required") if gitignore["required"].empty?
contents.delete(".gitignore") if contents[".gitignore"].empty?

contents.delete("spec/default_facts.yml") if contents["spec/default_facts.yml"] == {"unmanaged" => true}

[".travis.yml", "appveyor.yml"].each do |f|
  contents[f] ||= {}
  if contents[f]["unmanaged"] != true && contents[f]["delete"] != true
    contents[f]["simplecov"] = true
  end
end

contents = Hash[contents.keys.sort{|a,b| a.upcase <=> b.upcase}.map{|k| [k, contents[k]]}]
File.open(".sync.yml", "w") { |file| file.write(contents.to_yaml(line_width: 200)) }

@DavidS DavidS requested a review from a team as a code owner November 25, 2019 18:46
@DavidS DavidS changed the title pdksync - (maint) enable simplecove and minor cleanups (WIP) pdksync - (maint) enable simplecove and minor cleanups Nov 27, 2019
@DavidS DavidS changed the title (WIP) pdksync - (maint) enable simplecove and minor cleanups (MODULES-10120) enable simplecov; update to PDK 1.14.1; minor cleanups Nov 27, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@d15af63). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #268   +/-   ##
=======================================
  Coverage          ?     0%           
=======================================
  Files             ?      2           
  Lines             ?    183           
  Branches          ?      0           
=======================================
  Hits              ?      0           
  Misses            ?    183           
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d15af63...125ac5a. Read the comment docs.

@sanfrancrisko sanfrancrisko merged commit d9771bd into master Nov 29, 2019
@sanfrancrisko sanfrancrisko deleted the pdksync_simplecov branch November 29, 2019 13:49
@glennsarti
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants