Skip to content

(MODULES-11053) Add a note about the contains method #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2021
Merged

(MODULES-11053) Add a note about the contains method #1184

merged 1 commit into from
Apr 26, 2021

Conversation

@DavidS
Copy link
Contributor

@DavidS DavidS commented Apr 26, 2021

No description provided.

@DavidS DavidS requested a review from a team as a code owner April 26, 2021 09:31
@puppet-community-rangefinder
Copy link

puppet-community-rangefinder bot commented Apr 26, 2021

anchor is a type

Breaking changes to this file MAY impact these 612 modules (near match):

This module is declared in 318 of 576 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

sanfrancrisko
sanfrancrisko suggested changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@sanfrancrisko sanfrancrisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubocop doesn't seem happy with that change: https://github.com/puppetlabs/puppetlabs-stdlib/pull/1184/checks?check_run_id=2436852428#step:9:27

@sanfrancrisko sanfrancrisko merged commit 81dd738 into main Apr 26, 2021
@sanfrancrisko sanfrancrisko deleted the DavidS-patch-1 branch April 26, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sanfrancrisko sanfrancrisko sanfrancrisko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DavidS @sanfrancrisko