Bug in `mkDom`?

[jasonzoladz]

I think the changes related to the addition of IsDynamic have introduced a bug to the mkDom function, which breaks createElement in the where clause. See below.

[ethul]

Thanks for the report. I will take a look.

On Sunday, 31 January 2016, jasonzoladz notifications@github.com wrote:

I think the changes related to the addition of IsDynamic have introduced
a bug to the mkDom function, which breaks createElement in the where
clause. See below.

[image: screen shot 2016-01-31 at 6 43 08 pm]
https://cloud.githubusercontent.com/assets/8467728/12706121/e324589a-c84b-11e5-9b7e-0b27164207d2.png
[image: screen shot 2016-01-31 at 6 43 56 pm]
https://cloud.githubusercontent.com/assets/8467728/12706122/e6e85c06-c84b-11e5-8922-653085ba3e04.png

—
Reply to this email directly or view it on GitHub
#58.

[ethul]

Actually, I think we have a module naming issue. Can you try to clean your
purescript output and recompile with "--require-path=../"

On Sunday, 31 January 2016, Eric Thul thul.eric@gmail.com wrote:

Thanks for the report. I will take a look.

On Sunday, 31 January 2016, jasonzoladz <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

I think the changes related to the addition of IsDynamic have introduced
a bug to the mkDom function, which breaks createElement in the where
clause. See below.

[image: screen shot 2016-01-31 at 6 43 08 pm]
https://cloud.githubusercontent.com/assets/8467728/12706121/e324589a-c84b-11e5-9b7e-0b27164207d2.png
[image: screen shot 2016-01-31 at 6 43 56 pm]
https://cloud.githubusercontent.com/assets/8467728/12706122/e6e85c06-c84b-11e5-8922-653085ba3e04.png

—
Reply to this email directly or view it on GitHub
#58.

[jasonzoladz]

Thanks for the quick response.

I just tried to compile and load purescript-react-example (instead of my own project) and had the same issue, using pulp 8.0. Then I downgraded to pulp 7.0 and it worked. . . Closing while I figure out what is going on. I hate JS tooling.

[ethul]

Thanks for digging into this. Please keep me posted.

On Sunday, 31 January 2016, jasonzoladz notifications@github.com wrote:

Closed #58
#58.

—
Reply to this email directly or view it on GitHub
#58 (comment)
.

[jasonzoladz]

Really strange behavior. Back at pulp 8.0 and I have to:

1. delete "output"
2. "pulp build -r=../"
3. "pulp browserify --to bundle.js"

on every source change, else I get errors like the one below . . . Any clue?

[ethul]

Are you using -r=../ with watch enabled for pulp? Is there a way to
check if it is passed through to psc?

On Sunday, 31 January 2016, jasonzoladz notifications@github.com wrote:

Really strange behavior. Back at pulp 8.0 and I have to:

1. delete "output"
2. "pulp build -r=../"
3. "pulp browserify --to bundle.js"

on every source change, else I get errors like the one below . . . Any
clue?

[image: screen shot 2016-01-31 at 8 15 20 pm]
https://cloud.githubusercontent.com/assets/8467728/12706699/f9a04618-c857-11e5-8efb-7a65c3c160b7.png

—
Reply to this email directly or view it on GitHub
#58 (comment)
.

[ethul]

Also, can you paste the generated JavaScript before step 3?

On Sunday, 31 January 2016, Eric Thul thul.eric@gmail.com wrote:

Are you using -r=../ with watch enabled for pulp? Is there a way to
check if it is passed through to psc?

On Sunday, 31 January 2016, jasonzoladz <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Really strange behavior. Back at pulp 8.0 and I have to:

1. delete "output"
2. "pulp build -r=../"
3. "pulp browserify --to bundle.js"

on every source change, else I get errors like the one below . . . Any
clue?

[image: screen shot 2016-01-31 at 8 15 20 pm]
https://cloud.githubusercontent.com/assets/8467728/12706699/f9a04618-c857-11e5-8efb-7a65c3c160b7.png

—
Reply to this email directly or view it on GitHub
#58 (comment)
.

[jasonzoladz]

I haven't been using watch for this. Let me see if it's passed through to psc.

Here's the index.js before step 3 (it's a pruned version of your react example):

// Generated by psc version 0.8.0.0
"use strict";
var Prelude = require("Prelude");
var Control_Monad_Eff = require("Control.Monad.Eff");
var Control_Monad_Eff_Console = require("Control.Monad.Eff.Console");
var Data_Maybe_Unsafe = require("Data.Maybe.Unsafe");
var Data_Nullable = require("Data.Nullable");
var DOM = require("DOM");
var DOM_HTML = require("DOM.HTML");
var DOM_HTML_Types = require("DOM.HTML.Types");
var DOM_HTML_Window = require("DOM.HTML.Window");
var DOM_Node_NonElementParentNode = require("DOM.Node.NonElementParentNode");
var DOM_Node_Types = require("DOM.Node.Types");
var React = require("React");
var ReactDOM = require("ReactDOM");
var React_DOM = require("React.DOM");
var React_DOM_Props = require("React.DOM.Props");
var hello = React.createClass(React.spec(Prelude.unit)(function (ctx) {
    return function __do() {
        var v = React.getProps(ctx)();
        return React_DOM.h1([ React_DOM_Props.className("Hello"), React_DOM_Props.style({
            background: "lightgray"
        }) ])([ React_DOM.text("Hello, "), React_DOM.text(v.name), React.createElement(React.createClassStateless(function (props1) {
            return React_DOM["div'"]([ React_DOM.text(" World!  " + props1.test) ]);
        }))({
            test: "test"
        })([  ]) ]);
    };
}));
var elm$prime = function __do() {
    var v = DOM_HTML.window();
    var v1 = DOM_HTML_Window.document(v)();
    var v2 = DOM_Node_NonElementParentNode.getElementById("pip")(DOM_Node_Types.documentToNonElementParentNode(DOM_HTML_Types.htmlDocumentToDocument(v1)))();
    return Data_Maybe_Unsafe.fromJust(Data_Nullable.toMaybe(v2));
};
var main = (function () {
    var ui = React_DOM["div'"]([ React.createFactory(hello)({
        name: "World"
    }) ]);
    return Prelude["void"](Control_Monad_Eff.functorEff)(Prelude[">>="](Control_Monad_Eff.bindEff)(elm$prime)(ReactDOM.render(ui)));
})();
module.exports = {
    "elm'": elm$prime, 
    main: main, 
    hello: hello
};

[ethul]

Notice the require statements. They should start with ../

On Sunday, 31 January 2016, jasonzoladz notifications@github.com wrote:

I haven't been using watch for this. Let me see if it's passed through to
psc.

Here's the index.js before step 3:

// Generated by psc version 0.8.0.0"use strict";var Prelude = require("Prelude");var Control_Monad_Eff = require("Control.Monad.Eff");var Control_Monad_Eff_Console = require("Control.Monad.Eff.Console");var Data_Maybe_Unsafe = require("Data.Maybe.Unsafe");var Data_Nullable = require("Data.Nullable");var DOM = require("DOM");var DOM_HTML = require("DOM.HTML");var DOM_HTML_Types = require("DOM.HTML.Types");var DOM_HTML_Window = require("DOM.HTML.Window");var DOM_Node_NonElementParentNode = require("DOM.Node.NonElementParentNode");var DOM_Node_Types = require("DOM.Node.Types");var React = require("React");var ReactDOM = require("ReactDOM");var React_DOM = require("React.DOM");var React_DOM_Props = require("React.DOM.Props");var hello = React.createClass(React.spec(Prelude.unit)(function (ctx) {
return function __do() {
var v = React.getProps(ctx)();
return React_DOM.h1([ React_DOM_Props.className("Hello"), React_DOM_Props.style({
background: "lightgray"
}) ])([ React_DOM.text("Hello, "), React_DOM.text(v.name), React.createElement(React.createClassStateless(function (props1) {
return React_DOM["div'"]([ React_DOM.text%28" World! " + props1.test%29 ]%29;
}%29%29%28{
test: "test"
})([ ]) ]);
};
}));var elm$prime = function __do() {
var v = DOM_HTML.window();
var v1 = DOM_HTML_Window.document(v)();
var v2 = DOM_Node_NonElementParentNode.getElementById("pip")(DOM_Node_Types.documentToNonElementParentNode(DOM_HTML_Types.htmlDocumentToDocument(v1)))();
return Data_Maybe_Unsafe.fromJust(Data_Nullable.toMaybe(v2));
};var main = (function () {
var ui = React_DOM["div'"]([ React.createFactory%28hello%29%28{
name: "World"
}) ]);
return Prelude"void"(Prelude">>="(elm$prime)(ReactDOM.render(ui)));
})();module.exports = {
"elm'": elm$prime,
main: main,
hello: hello
};

—
Reply to this email directly or view it on GitHub
#58 (comment)
.

[jasonzoladz]

Yep.

The problem is that the three steps don't always work. I'm starting to get this (see below) randomly, so it looks like a module loading problem. Yikes.

Thanks for your help.

[ethul]

Welcome. Do you know where the problem is stemming from?

On Sunday, 31 January 2016, jasonzoladz notifications@github.com wrote:

Yep.

The problem is that the three steps don't always work. I'm starting to get
this (see below) randomly, so it looks like a module loading problem. Yikes.

Thanks for your help.

[image: screen shot 2016-01-31 at 8 55 13 pm]
https://cloud.githubusercontent.com/assets/8467728/12707081/f4e83c20-c85c-11e5-95e2-284729639ddf.png

—
Reply to this email directly or view it on GitHub
#58 (comment)
.

[jasonzoladz]

Unfortunately no. But I have to put it to bed for the night or my wife will bludgeon me.

I'll dig into this tomorrow.

[ethul]

Got it. Keep me posted on the issue.

On Sunday, 31 January 2016, jasonzoladz notifications@github.com wrote:

Unfortunately no. But I have to put it to bed for the night or my wife
will bludgeon me.

I'll dig into this tomorrow.

—
Reply to this email directly or view it on GitHub
#58 (comment)
.

[jasonzoladz]

The problem appears multifaceted:

• a change of require-path doesn't cause a rebuild: Change of --require-path not causing a rebuild purescript/purescript#1836
• when I try to rely on the $NODE_PATH, the case-insensitive mac file system causes conflicts (react/index.js vs. React/index.js; react/foreign.js vs. React/foreign.js)
• right now, dependency management for PS is a house of cards