Skip to content

Add react-icons v1.0.3#1192

Merged
thomashoneyman merged 3 commits intopurescript:masterfrom
andys8:add-purescript-react-icons
Jul 9, 2022
Merged

Add react-icons v1.0.3#1192
thomashoneyman merged 3 commits intopurescript:masterfrom
andys8:add-purescript-react-icons

Conversation

@andys8
Copy link
Contributor

@andys8 andys8 commented Jul 9, 2022

Adding my newly created package react-icons (PureScript bindings for react-icons).

@andys8
Copy link
Contributor Author

andys8 commented Jul 9, 2022

Build failed. Potentially because of module size. Looking into it...

https://discordapp.com/channels/864614189094928394/867149806178664478/995309795777187871

@andys8 andys8 changed the title Add react-icons v1.0.1 Add react-icons v1.0.2 Jul 9, 2022
@thomashoneyman
Copy link
Member

Huh — haven't seen this happen before! But we do need this module to compile in order to make it into the package sets. Let's keep this open for the time being.

@andys8 andys8 changed the title Add react-icons v1.0.2 Add react-icons v1.0.3 Jul 9, 2022
@andys8
Copy link
Contributor Author

andys8 commented Jul 9, 2022

Will only expose the react components instead of helper functions to reduce output size and compile time.
purescript-react/purescript-react-icons#2

@thomashoneyman thomashoneyman merged commit 0029dc3 into purescript:master Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants