Skip to content

Conversation

@joshuahhh
Copy link
Contributor

This is based off the v1.1.0 tag, since the newer versions require newer versions of Purescript... I'll be happy to rebase when things settle down, or anyone else can feel free to do so.

PTAL – thanks!

@paf31
Copy link
Contributor

paf31 commented Oct 18, 2016

Looks good, thanks!

Do you need this now for 0.9.3? I think we could probably make a v1.2.0 tag off of v1.1.0 (@garyb?) if so. If it's not urgent, I think let's rebase this on top of master, since it should be easier to upgrade soon.

@joshuahhh
Copy link
Contributor Author

Not urgent at all. I just didn't want to mess around with 0.10.1 yet (to run tests for this).

I'll rebase off master and see if the Travis build gives me the confidence I need!

@hdgarrood
Copy link
Contributor

What do people think about using import Data.Array as A in the tests instead of an explicit import list? That could help prevent conflicts like this one.

@garyb
Copy link
Member

garyb commented Nov 20, 2016

Yeah, sounds good to me.

@hdgarrood hdgarrood mentioned this pull request Nov 20, 2016
@hdgarrood
Copy link
Contributor

hdgarrood commented Nov 20, 2016

I merged your commit in #82. Thanks!

@hdgarrood hdgarrood closed this Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants