Remove a couple of uses of uncons #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also did |
hdgarrood
force-pushed
the
remove-uncons
branch
from
6fbaed0 to
8f9dc9c
Compare
By using index rather than uncons.
Just use an integer index for the unfolding, as opposed to the uncons' implementation, which was constructing all of the tails of the input array.
hdgarrood
force-pushed
the
remove-uncons
branch
from
8f9dc9c to
58fa234
Compare
|
Rebased and removed the commit with the shadowing fix, since that has been done separately. I think this is good to go now. |
|
👍 Great improvements, thanks! |
|
I won't publish a new release just yet because I am planning to send another similar PR shortly. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76, partially addresses #71.
I benchmarked this toUnfoldable vs the current one and my suggested one seems to win fairly convincingly: