Use unit #1
Use unit #1
Conversation
There was a problem hiding this comment.
One very slight issue here: these various FFI calls return {}, which doesn't have the runtime representation of the type Unit, so pattern matching on the result, for example, while not necessarily useful, could result in a runtime error. To be super safe, these things should probably return Prelude.unit.
There was a problem hiding this comment.
Yeah, I did have a slight worry about that. I checked the generated code for Eq, Ord, things like that and none of them attempt to read from the value so I think at least in PS code it should be fine. I also figure this'll be fixed when we get newtypes working.
There was a problem hiding this comment.
Ok, so this is a problem actually when compiled with no optimizations. One fix is to not pattern match in the Prelude definitions, just use _ instead of (Unit {}). I've updated the Prelude in ps-in-ps to have the definitions this way so it's not broken in psci.
@paf31