Relax some version bounds and fix build with Cabal 3.#3838
Relax some version bounds and fix build with Cabal 3.#3838arrowd wants to merge 1 commit intopurescript:masterfrom
Conversation
|
If breaking compatibility with Cabal < 3 is a concern, let's at least partially merge this? |
|
Sorry, but this sort of change is not really a priority for us. In particular building the compiler with dependencies other than those specified by stack.yaml is not recommended. If this is blocking you elsewhere because your distribution provides newer versions of libraries etc, I would recommend that you find a different way of building the compiler. |
|
The PR is failing on CI, because our Stackage snapshot contains a version of Protolude that doesn't export |
|
Yeah I mean we definitely will want to do it eventually - I just mean that doing it soon is going to be difficult to justify based on the other things we could be looking at. |
|
Such as getting 0.14.0 out the door. |
|
No problem, I can surely patch Purescript on our side. I just wanted to minimize amount of extra patches. Is there any ETA for a release that would have my happy fix in? |
|
The next release will be 0.14.0, and it shouldn’t be too far away, but it will have some breaking changes. However I still would like to encourage you not to maintain patches; whatever is breaking for you now will surely break again later, because we do not move at the same speed as the rest of the Haskell ecosystem. Can you use the instructions for building from source in INSTALL.md instead? |
If that means using Anyway, the most complex part (happy fix) is already upstreamed, so tiny Cabal 3 compatibility patches aren't a big deal. |
|
Using stack is easiest, but it doesn't necessarily mean using stack. It should be possible to turn the output of |
|
I'm going to close this because this widens version bounds more than I'm comfortable with, and also because I want to get #3933 in first, which will require this to be redone anyway. |
No description provided.