chore: evm derived-tx gas price fix + upgrade handler (donut) - #299
Merged
Conversation
…ckages - universalClient/chains -> universalClient/externalchains (external chains only) - universalClient/chains/push -> universalClient/pushwatcher, owned by core instead of the chains manager (no more ensurePushChain, fake ChainConfig, or ChainClient interface stubs) - core opens the push chain DB once and shares it with the TSS node
refactor(uclient): split push client out of chains manager; rename packages
Picks up pushchain/push-chain-evm#37 — derived txs now report the block base fee as gasPrice/effectiveGasPrice instead of 0.
chore: bump cosmos/evm to derived-tx gas price fix
No-op handler (RunMigrations, empty StoreUpgrades) for the cosmos/evm bump picking up the derived-tx gas price fix.
Resolves app/upgrades.go by keeping donut's full historical handler list and appending evm-derived-gas-price.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the
cosmos/evmderived-tx gas-price fix totestnet/donut, with the upgrade handlerneeded to coordinate the binary swap.
What this changes
1. The evm bump (already merged to
developvia #298)Picks up push-chain-evm#37. Blocks whose only
content is derived transactions currently render a negative block reward in explorers: derived
txs are rebuilt from ABCI events with
GasFeeCap = GasTipCap = 0, so the EIP-1559 formula reportsgasPrice = 0whilegasUsed > 0. Reproduced on live donut (block0x13a5ce8):The fix reports the block base fee for derived txs, so the arithmetic nets to zero. JSON-RPC
reporting only — no consensus or state changes.
2. The
evm-derived-gas-priceupgrade handlerNo-op:
RunMigrationswith emptyStoreUpgrades. Appended aftersdkv053; all 38 historicalhandlers are preserved (the merge conflict in
app/upgrades.gowas resolved by keeping donut's fulllist and appending, not by taking the
developside, which has an emptyUpgradesslice).testnet/donutwas 4 commits behinddevelop, so this PR necessarily brings theuclient refactor (#297) along with it —
package renames (
universalClient/chains/push→universalClient/pushwatcher) and the TSS packagereshuffle. That is the bulk of the 66-file diff; only
go.mod/go.sumand the two handler filesrelate to this change.
Worth a look if the uclient refactor wasn't already intended for donut.
Validation
Upgrade simulation
release/v1.1.38-donut(= currenttestnet/donut,71d3a569) → this branch:go build ./...clean.Not covered by the simulation: the local testnet has no derived transactions (they come from
uexecutor cross-chain activity), so the gas-price fix itself wasn't observable there. The fix is
validated separately by the unit tests in push-chain-evm#37 and by the live-donut reproduction above.