This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Fix support for spaces in parameters#49
Merged
samuelyallop-pusher merged 4 commits intomasterfrom Feb 25, 2020
Merged
Conversation
samuelyallop-pusher
force-pushed
the
fix-space-encoding
branch
from
f802d5b to
1edb986
Compare
samuelyallop-pusher
force-pushed
the
fix-space-encoding
branch
from
17210db to
805b3eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Methods whose parameters contain spaces and were interpolated into URI path segments were incorrectly encoded. For example, user ids containing spaces when passed to
get_user_roomshad spaces encoded as '+' (suitable for query strings) not '%20'.How
Replace use of
CGI::escapein paths with a helper for path segments.