End-to-end encryption #86
Conversation
WillSewell
left a comment
WillSewell
left a comment
There was a problem hiding this comment.
Generally looks good. Let me know your thoughts on my comments @jameshfisher. I'm happy to act on them if you don't have the time. As you say, it's missing tests. I will have a go at adding some.
|
These tests should pass, but they seem to be broken by NodeJS breaking changes. There are two NodeJS APIs for decoding buffers: TextDecoder and StringDecoder. TextDecoder is not available until recent versions? StringDecoder seems to change behavior: on NodeJS version 10+, it works as expected, returning e.g. |
WillSewell
left a comment
WillSewell
left a comment
There was a problem hiding this comment.
It's looking good. But it does sound like we'll need to test for new node versions first :(
In case you forget, I think this new functionality should be documented in the README as part of this PR.
Also, I see you moved isEncryptedChannel to util.js. I think you might have missed my PR also moves #90, which also moves channelSharedSecret. It's not a big deal, so I'll let you decide whether you want to merge or close it.
WillSewell
force-pushed
the
end-to-end-encryption
branch
from
2a6fc53 to
459e378
Compare
…uth for encrypted channel but we don't have the master key
WillSewell
force-pushed
the
end-to-end-encryption
branch
from
b79b8ef to
d697baf
Compare
No, it doesn't have tests. Yes, it should have tests.