Skip to content

Channel(s) parameter can now be a collection or a string #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jpatel531 merged 1 commit into from
Mar 25, 2015
Merged

Channel(s) parameter can now be a collection or a string #41

jpatel531 merged 1 commit into from
Mar 25, 2015

Conversation

@jpatel531
Copy link
Contributor

@jpatel531 jpatel531 commented Mar 24, 2015

  1. Raises type error if the channels param is not a list or string
  2. Tests that TypeError is raised if channels param is not list or string
  3. string becomes [string]
  4. Tests the request is made properly with a string as channel

@leggetter
Copy link
Contributor

leggetter commented Mar 24, 2015

👍 it's got tests and everything!

@jpatel531
Copy link
Contributor Author

jpatel531 commented Mar 24, 2015

@danielwaterworth fair enough! i didn't think about people passing in sets

@jpatel531 jpatel531 force-pushed the channels_can_be_list_or_string branch from 4529274 to 3111e9c Compare March 24, 2015 12:05
@jpatel531 jpatel531 force-pushed the channels_can_be_list_or_string branch from 3111e9c to 4d7346a Compare March 24, 2015 12:07
@jpatel531 jpatel531 changed the title Channel(s) parameter can now be a list or a string Channel(s) parameter can now be a collection or a string Mar 24, 2015
jpatel531 added a commit that referenced this pull request Mar 25, 2015
@jpatel531
Merge pull request #41 from pusher/channels_can_be_list_or_string
5d3248d 
Channel(s) parameter can now be a collection or a string
@jpatel531 jpatel531 merged commit 5d3248d into 1.0.0 Mar 25, 2015
@jpatel531 jpatel531 deleted the channels_can_be_list_or_string branch April 27, 2015 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpatel531 @leggetter