Move functionality from Config to Pusher object #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jpatel531 @zimbatm - would love to be able to release this library sooner rather than later! A pragmatic approach to getting this shipped would be very much appreciated.
Main changes:
Pusherconstructor now takesapp_id,keyandsecret.configis an optional named param.Config.authenticate_subscription->Pusher.authenticateConfig.validate_webhook->Pusher.validate_webhookConfig.from_url->Pusher.from_urlConfig.from_env->Pusher.from_envOne failing test!
One interesting point to note. In the 1.0.0 branch all tests pass. In simple-paramters the
test_initialize_from_envtest fails (on my machine) since I'm using Python 2.7.9 and there's a test that sets SSL totrueandsync.pychecks at least Python 3.4 is installed. I cannot understand why this test doesn't fail on the 1.0.0 branch - it should! I did do some digging and it appearssys.version_infois empty in the 1.0.0 branch when running the test but full of values in thesimple-parametersbranch. I haz no clue!