Run with it #45

zimbatm · 2015-04-01T09:55:14Z

Taking #44 and going all the way.

TODO:

Unit tests for the adapters
Appengine compatibility

As a developer I would be looking for errors there

Allows to configure persistent connections

jpatel531 · 2015-04-01T15:14:51Z

sweet! can i merge?

leggetter · 2015-04-01T15:50:07Z

If we are definitely happy to do so without testing some of the alternative adapters (the TODO above), sure.

I'd also like the peace of mind of some acceptance tests that actually hit the Pusher APIs.

But, we can create issues for both of these.

jpatel531 · 2015-04-01T16:28:08Z

when i run the tests i'm getting:

AttributeError: 'module' object has no attribute 'create_default_context'
in sync.py ln 19

zimbatm · 2015-04-01T16:30:14Z

It definitely needs testing, looking for 30% feedback right now

leggetter · 2015-04-01T17:01:21Z

@jpatel531 What version of Python are you using?

jpatel531 · 2015-04-05T16:05:26Z

I've now tried it on 3.4

It's coming out with: bytes' object has no attribute 'encode' - which is failing every test

If it's any of the string types try to convert to string/text, otherwise raise a TypeError

zimbatm · 2015-04-09T13:00:57Z

It's still missing adapter tests. At this point the library has been tested manually against python 3.4.3, 2.7.2 and 2.6.7 with the various backends.

jpatel531 · 2015-04-13T12:56:59Z

For some reason the change to the packages list is failing the tests - it's looking for the folders within the pusher directory. Is that normal?

zimbatm · 2015-04-13T15:43:38Z

Why python version ?

it's looking for the folders within the pusher directory

I'm not sure what that means

jpatel531 · 2015-04-13T16:21:10Z

It was looking for the directory 'pusher/errors', 'pusher/aiohttp' etc.

jpatel531 · 2015-04-24T20:33:45Z

ok @zimbatm - i've tested it out on GAE with a new urlfetch backend, for which tests have been added (mind you - all the backend adapters only test for trigger success). everything's green on travis. there's probably still some stuff to do (like more tests), but i'm happy to get this up on pypi as soon as possible. WDYT?

zimbatm · 2015-04-24T20:37:41Z

🚢 🚀

Run with it

leggetter and others added 21 commits March 31, 2015 20:01

Pusher ctr now requires app_id, key, secret

315f10b

app_id, key, secret optional on Config ctr

5a14077

Move authenticate_subscription. Config -> Pusher

a0d359e

authenticate_subscription -> authenticate

547c752

Config.validate_webhook -> Pusher.validate_webhook

5bd4ac5

pusher.conf refs to pusher.config

2a54734

Merge branch '1.0.0' into simple-parameters

5480d62

Use functions on Pusher and not Config

c836f1b

Adding additional configuration docs

ec16a0d

Move signature code into it's own module

9b3439f

Remove artificial restriction on sync+SSL

773950f

Move request_method to pusher.request module

4a07ced

Get rid of the Config object

9c56cce

Keep all the @request_method together

90ab769

Move errors into their own modules

7e3fa88

As a developer I would be looking for errors there

Move all the http abstractions into a single pusher.http module

b0e2645

Restore two-step adapter initialisation

329a75d

Allows to configure persistent connections

Global config timeout

4941054

Tornado cleanup

474a44c

Add timeout to requests adapter

d2004fc

Add timeout and Keep-Alive to the aiohttp adapter

8fa7f44

zimbatm mentioned this pull request Apr 1, 2015

Move functionality from Config to Pusher object #44

Closed

jpatel531 and others added 2 commits April 6, 2015 21:23

'Fixed' tests

7a5161e

Make all the properties read-only

2ef4de4

zimbatm added 7 commits April 8, 2015 14:34

Allow to pass options to Pusher.from_env and Pusher.from_url

2614a62

Editorconfig

8e72996

Rework text handling

3ee8aa9

If it's any of the string types try to convert to string/text, otherwise raise a TypeError

Fix packages list in setup.py

259699c

Remove Sync backend. Requests backend is enough

06b5d05

Fix tornado and asyncio backends

6ce72d6

Add trigger examples

2c9570d

zimbatm force-pushed the run-with-it branch from cf87c83 to 2c9570d Compare April 8, 2015 21:26

https

f6d0605

zimbatm mentioned this pull request Apr 9, 2015

GAE urlfetch #39

Closed

Started adding tests for http adapters.

b0970ab

jpatel531 force-pushed the run-with-it branch from 018e3f6 to b0970ab Compare April 23, 2015 10:36

zimbatm and others added 2 commits April 24, 2015 11:03

Fixes loading and testing issues in python 2.6

0b878fe

Renamed package to pusher and updated version number

a6e8e0e

jpatel531 force-pushed the run-with-it branch from 18c6623 to 11363bc Compare April 24, 2015 16:08

Added urlfetch adapter

ba98601

jpatel531 force-pushed the run-with-it branch from 11363bc to ba98601 Compare April 24, 2015 17:04

Added tests for urlfetch adapter

b0b40a5

jpatel531 force-pushed the run-with-it branch from 5eb529d to b0b40a5 Compare April 24, 2015 19:46

jpatel531 added 2 commits April 24, 2015 21:05

Amended .travis.yml to account for extras

ab6e93e

Renamed urlfetch adapter test and made it import unittest2 if v2.6

3a92622

jpatel531 added a commit that referenced this pull request Apr 24, 2015

Merge pull request #45 from pusher/run-with-it

a49b73d

Run with it

jpatel531 merged commit a49b73d into 1.0.0 Apr 24, 2015

zimbatm deleted the run-with-it branch May 18, 2015 15:51

Run with it #45

Run with it #45

Uh oh!

Conversation

zimbatm commented Apr 1, 2015

Uh oh!

jpatel531 commented Apr 1, 2015

Uh oh!

leggetter commented Apr 1, 2015

Uh oh!

jpatel531 commented Apr 1, 2015

Uh oh!

zimbatm commented Apr 1, 2015

Uh oh!

leggetter commented Apr 1, 2015

Uh oh!

jpatel531 commented Apr 5, 2015

Uh oh!

zimbatm commented Apr 9, 2015

Uh oh!

jpatel531 commented Apr 13, 2015

Uh oh!

zimbatm commented Apr 13, 2015

Uh oh!

jpatel531 commented Apr 13, 2015

Uh oh!

jpatel531 commented Apr 24, 2015

Uh oh!

zimbatm commented Apr 24, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants